Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1770353002: Annotate runtime call stats with trace events (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
Reviewers:
fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Annotate runtime call stats with trace events I used a new category "v8.runtime" and all events are disabled by default, so there shouldn't be any perf impact. BUG=none R=fmeawad@chromium.org,cbruni@chromium.org Committed: https://crrev.com/34a47649e89bc7027843f779a1baa46fab185edf Cr-Commit-Position: refs/heads/master@{#34620}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/arguments.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/vm-state-inl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-08 10:41:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770353002/1
4 years, 9 months ago (2016-03-08 13:36:24 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-08 13:36:26 UTC) #6
Camillo Bruni
On 2016/03/08 at 10:41:30, jochen wrote: > I still have to investigate a performance regression ...
4 years, 9 months ago (2016-03-08 13:37:38 UTC) #7
jochen (gone - plz use gerrit)
On 2016/03/08 at 13:37:38, cbruni wrote: > On 2016/03/08 at 10:41:30, jochen wrote: > > ...
4 years, 9 months ago (2016-03-08 13:43:52 UTC) #8
Camillo Bruni
On 2016/03/08 at 13:43:52, jochen wrote: > On 2016/03/08 at 13:37:38, cbruni wrote: > > ...
4 years, 9 months ago (2016-03-08 14:05:01 UTC) #10
jochen (gone - plz use gerrit)
On 2016/03/08 at 14:05:01, cbruni wrote: > On 2016/03/08 at 13:43:52, jochen wrote: > > ...
4 years, 9 months ago (2016-03-08 14:07:11 UTC) #11
jochen (gone - plz use gerrit)
btw, which benchmark do they tank?
4 years, 9 months ago (2016-03-08 15:42:40 UTC) #12
Camillo Bruni
On 2016/03/08 at 15:42:40, jochen wrote: > btw, which benchmark do they tank? v8-perf/benchmarks/SunSpiderGolem/SunSpiderGolemStringFasta.js seems ...
4 years, 9 months ago (2016-03-08 17:04:33 UTC) #13
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-08 17:04:36 UTC) #14
fmeawad
LGTM v8.runtime is the correct format. I will monitor the perf waterfall for any regression ...
4 years, 9 months ago (2016-03-08 17:46:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770353002/40001
4 years, 9 months ago (2016-03-09 12:46:43 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 13:09:29 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 13:09:48 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34a47649e89bc7027843f779a1baa46fab185edf
Cr-Commit-Position: refs/heads/master@{#34620}

Powered by Google App Engine
This is Rietveld 408576698