src/builtins.cc - Issue 1770353002: Annotate runtime call stats with trace events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1770353002: Annotate runtime call stats with trace events (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 5f062e1c95c0af883ccc898e8b42310b7ff252bf..dd85e7d1cc18595cd9ac4b25af82e89660fb250f 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -145,6 +145,8 @@ BUILTIN_LIST_C(DEF_ARG_TYPE)

isolate->counters()->runtime_calls()->Increment(); \

RuntimeCallStats* stats = isolate->counters()->runtime_call_stats(); \

RuntimeCallTimerScope timer(isolate, &stats->Builtin_##name); \

+ TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \

+ "V8.Builtin_" #name); \

name##ArgumentsType args(args_length, args_object); \

Object* value = Builtin_Impl_##name(args, isolate); \

return value; \

« no previous file with comments | « src/arguments.h ('k') | src/vm-state-inl.h » ('j') | no next file with comments »