Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1771323003: [counter] reducing the overhead of RuntimeCallTimerScope (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counter] reducing the overhead of RuntimeCallTimerScope BUG=chromium:589679 LOG=N Committed: https://crrev.com/667b04a94a6ccda3fe0c9af54c2f0d51c31a6bf9 Cr-Commit-Position: refs/heads/master@{#34595}

Patch Set 1 #

Patch Set 2 : further reducing overhead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -30 lines) Patch
M src/arguments.h View 1 1 chunk +15 lines, -10 lines 0 comments Download
M src/counters.h View 3 chunks +18 lines, -5 lines 0 comments Download
M src/counters.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M src/d8.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/vm-state-inl.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL, this should improve the runtime call stats overhead by 20% when enabled and reduce ...
4 years, 9 months ago (2016-03-08 15:22:01 UTC) #4
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-08 16:56:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771323003/20001
4 years, 9 months ago (2016-03-08 17:01:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 17:24:05 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:24:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/667b04a94a6ccda3fe0c9af54c2f0d51c31a6bf9
Cr-Commit-Position: refs/heads/master@{#34595}

Powered by Google App Engine
This is Rietveld 408576698