third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 1768913002: Dynamic updation of checked and selected attributes should reflect correct :default status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1768913002: Dynamic updation of checked and selected attributes should reflect correct :default status (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html ('k') | third_party/WebKit/Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index 93a646bba876e24c5f8eeb4b5cfc57c7751ae6b8..6e578bebba09203b38b073e0b71bf4cb2c3a7053 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -722,6 +722,8 @@ void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr

setChecked(!value.isNull());

m_reflectsCheckedAttribute = true;

}

+ if (m_inputType->isCheckable())

tkent 2016/03/07 15:23:50 Please remove this |if|. We may call pseudoStateC

ramya.v 2016/03/08 03:22:06 Done.

+ pseudoStateChanged(CSSSelector::PseudoDefault);

} else if (name == maxlengthAttr) {

parseMaxLengthAttribute(value);

} else if (name == minlengthAttr) {