third_party/WebKit/Source/core/html/HTMLOptionElement.cpp - Issue 1768913002: Dynamic updation of checked and selected attributes should reflect correct :default status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

Issue 1768913002: Dynamic updation of checked and selected attributes should reflect correct :default status (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

index 3a1b25d02d201599303ee361398ce1562107aaaa..f159f0982e25052845d653447788655faabf1452 100644

--- a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

@@ -216,6 +216,7 @@ void HTMLOptionElement::parseAttribute(const QualifiedName& name, const AtomicSt

} else if (name == selectedAttr) {

if (oldValue.isNull() != value.isNull() && !m_isDirty)

setSelected(!value.isNull());

+ pseudoStateChanged(CSSSelector::PseudoDefault);

} else if (name == labelAttr) {

updateLabel();

} else {

« third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | no next file » | no next file with comments »