Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1768913002: Dynamic updation of checked and selected attributes should reflect correct :default status (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 m_inputTypeView->valueAttributeChanged(); 715 m_inputTypeView->valueAttributeChanged();
716 } else if (name == checkedAttr) { 716 } else if (name == checkedAttr) {
717 // Another radio button in the same group might be checked by state 717 // Another radio button in the same group might be checked by state
718 // restore. We shouldn't call setChecked() even if this has the checked 718 // restore. We shouldn't call setChecked() even if this has the checked
719 // attribute. So, delay the setChecked() call until 719 // attribute. So, delay the setChecked() call until
720 // finishParsingChildren() is called if parsing is in progress. 720 // finishParsingChildren() is called if parsing is in progress.
721 if (!m_parsingInProgress && m_reflectsCheckedAttribute) { 721 if (!m_parsingInProgress && m_reflectsCheckedAttribute) {
722 setChecked(!value.isNull()); 722 setChecked(!value.isNull());
723 m_reflectsCheckedAttribute = true; 723 m_reflectsCheckedAttribute = true;
724 } 724 }
725 if (m_inputType->isCheckable())
tkent 2016/03/07 15:23:50 Please remove this |if|. We may call pseudoStateC
ramya.v 2016/03/08 03:22:06 Done.
726 pseudoStateChanged(CSSSelector::PseudoDefault);
725 } else if (name == maxlengthAttr) { 727 } else if (name == maxlengthAttr) {
726 parseMaxLengthAttribute(value); 728 parseMaxLengthAttribute(value);
727 } else if (name == minlengthAttr) { 729 } else if (name == minlengthAttr) {
728 parseMinLengthAttribute(value); 730 parseMinLengthAttribute(value);
729 } else if (name == sizeAttr) { 731 } else if (name == sizeAttr) {
730 int oldSize = m_size; 732 int oldSize = m_size;
731 m_size = defaultSize; 733 m_size = defaultSize;
732 int valueAsInteger; 734 int valueAsInteger;
733 if (!value.isEmpty() && parseHTMLInteger(value, valueAsInteger) && value AsInteger > 0) 735 if (!value.isEmpty() && parseHTMLInteger(value, valueAsInteger) && value AsInteger > 0)
734 m_size = valueAsInteger; 736 m_size = valueAsInteger;
(...skipping 1209 matching lines...) Expand 10 before | Expand all | Expand 10 after
1944 void HTMLInputElement::ensurePrimaryContent() 1946 void HTMLInputElement::ensurePrimaryContent()
1945 { 1947 {
1946 m_inputTypeView->ensurePrimaryContent(); 1948 m_inputTypeView->ensurePrimaryContent();
1947 } 1949 }
1948 1950
1949 bool HTMLInputElement::hasFallbackContent() const 1951 bool HTMLInputElement::hasFallbackContent() const
1950 { 1952 {
1951 return m_inputTypeView->hasFallbackContent(); 1953 return m_inputTypeView->hasFallbackContent();
1952 } 1954 }
1953 } // namespace blink 1955 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698