Move UTF16ToASCII, remove WideToASCII.

Move UTF16ToASCII, remove WideToASCII.

This removes WideToASCII and changes all callers to use UTF16ToASCII instead.

Moves UTF16ToASCII from base/strings/string_util.h to base/strings/utf_string_conversions.h and into the base namespace.

Convert a few related string_util functions to take a StringPiece16 instead of a string16. Remove IsStringASCII(std::wstring) which was unused.

Updates callers' includes and namespace usage accordingly.

TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257200

[brettw, 2014-03-14 05:00:02]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-03-14 05:00:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/176843022/150001

[commit-bot: I haz the power, 2014-03-14 05:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 05:01:44]

Failed to apply patch for
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
  Hunk #2 FAILED at 3167.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc.rej

Patch:       chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index
734cffcbd6d51efe4aae138cb9ebcb90b339ea26..055c20b86a293c7ec1f2525a574983410bc4c5ec
100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -2924,7 +2924,7 @@ void AutofillDialogControllerImpl::SuggestionsUpdated() {
         const AutofillProfile& profile = *profiles[i];
         if (!i18ninput::AddressHasCompleteAndVerifiedData(profile) ||
             !i18ninput::CountryIsFullySupported(
-                UTF16ToASCII(profile.GetRawInfo(ADDRESS_HOME_COUNTRY)))) {
+                base::UTF16ToASCII(profile.GetRawInfo(ADDRESS_HOME_COUNTRY))))
{
           continue;
         }
 
@@ -3167,7 +3167,7 @@ bool AutofillDialogControllerImpl::ShouldSuggestProfile(
     DialogSection section,
     const AutofillProfile& profile) {
   return CanAcceptCountry(
-      section, UTF16ToASCII(profile.GetRawInfo(ADDRESS_HOME_COUNTRY)));
+      section, base::UTF16ToASCII(profile.GetRawInfo(ADDRESS_HOME_COUNTRY)));
 }
 
 SuggestionsMenuModel* AutofillDialogControllerImpl::

[brettw, 2014-03-14 21:12:07]

Committed patchset #11 manually as r257200 (presubmit successful).