Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/app/client_util.cc

Issue 176843022: Move UTF16ToASCII, remove WideToASCII. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <windows.h> 5 #include <windows.h>
6 #include <shlwapi.h> 6 #include <shlwapi.h>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 return base::string16(); 201 return base::string16();
202 base::string16 exe_path(path); 202 base::string16 exe_path(path);
203 return exe_path.append(1, L'\\'); 203 return exe_path.append(1, L'\\');
204 } 204 }
205 205
206 base::string16 GetCurrentModuleVersion() { 206 base::string16 GetCurrentModuleVersion() {
207 scoped_ptr<FileVersionInfo> file_version_info( 207 scoped_ptr<FileVersionInfo> file_version_info(
208 FileVersionInfo::CreateFileVersionInfoForCurrentModule()); 208 FileVersionInfo::CreateFileVersionInfoForCurrentModule());
209 if (file_version_info.get()) { 209 if (file_version_info.get()) {
210 base::string16 version_string(file_version_info->file_version()); 210 base::string16 version_string(file_version_info->file_version());
211 if (Version(WideToASCII(version_string)).IsValid()) 211 if (Version(base::UTF16ToASCII(version_string)).IsValid())
212 return version_string; 212 return version_string;
213 } 213 }
214 return base::string16(); 214 return base::string16();
215 } 215 }
216 216
217 //============================================================================= 217 //=============================================================================
218 218
219 MainDllLoader::MainDllLoader() 219 MainDllLoader::MainDllLoader()
220 : dll_(NULL), metro_mode_(InMetroMode()) { 220 : dll_(NULL), metro_mode_(InMetroMode()) {
221 } 221 }
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 } 362 }
363 }; 363 };
364 364
365 MainDllLoader* MakeMainDllLoader() { 365 MainDllLoader* MakeMainDllLoader() {
366 #if defined(GOOGLE_CHROME_BUILD) 366 #if defined(GOOGLE_CHROME_BUILD)
367 return new ChromeDllLoader(); 367 return new ChromeDllLoader();
368 #else 368 #else
369 return new ChromiumDllLoader(); 369 return new ChromiumDllLoader();
370 #endif 370 #endif
371 } 371 }
OLDNEW
« no previous file with comments | « base/strings/utf_string_conversions.cc ('k') | chrome/browser/autocomplete/autocomplete_input.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698