Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/installer/util/installer_state_unittest.cc

Issue 176843022: Move UTF16ToASCII, remove WideToASCII. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <windows.h> 5 #include <windows.h>
6 6
7 #include <fstream> 7 #include <fstream>
8 8
9 #include "base/base_paths.h" 9 #include "base/base_paths.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 expected_remaining_dirs.insert(kOldChromeExeVersion); 582 expected_remaining_dirs.insert(kOldChromeExeVersion);
583 expected_remaining_dirs.insert(kChromeExeVersion); 583 expected_remaining_dirs.insert(kChromeExeVersion);
584 expected_remaining_dirs.insert(kNewChromeExeVersion); 584 expected_remaining_dirs.insert(kNewChromeExeVersion);
585 585
586 // Enumerate dirs in target_path(), ensure only desired remain. 586 // Enumerate dirs in target_path(), ensure only desired remain.
587 base::FileEnumerator version_enum(installer_state.target_path(), false, 587 base::FileEnumerator version_enum(installer_state.target_path(), false,
588 base::FileEnumerator::DIRECTORIES); 588 base::FileEnumerator::DIRECTORIES);
589 for (base::FilePath next_version = version_enum.Next(); !next_version.empty(); 589 for (base::FilePath next_version = version_enum.Next(); !next_version.empty();
590 next_version = version_enum.Next()) { 590 next_version = version_enum.Next()) {
591 base::FilePath dir_name(next_version.BaseName()); 591 base::FilePath dir_name(next_version.BaseName());
592 Version version(WideToASCII(dir_name.value())); 592 Version version(base::UTF16ToASCII(dir_name.value()));
593 if (version.IsValid()) { 593 if (version.IsValid()) {
594 EXPECT_TRUE(expected_remaining_dirs.erase(version.GetString())) 594 EXPECT_TRUE(expected_remaining_dirs.erase(version.GetString()))
595 << "Unexpected version dir found: " << version.GetString(); 595 << "Unexpected version dir found: " << version.GetString();
596 } 596 }
597 } 597 }
598 598
599 std::set<std::string>::const_iterator iter( 599 std::set<std::string>::const_iterator iter(
600 expected_remaining_dirs.begin()); 600 expected_remaining_dirs.begin());
601 for (; iter != expected_remaining_dirs.end(); ++iter) 601 for (; iter != expected_remaining_dirs.end(); ++iter)
602 ADD_FAILURE() << "Expected to find version dir for " << *iter; 602 ADD_FAILURE() << "Expected to find version dir for " << *iter;
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 // Critical update newer than the new version. 801 // Critical update newer than the new version.
802 EXPECT_FALSE( 802 EXPECT_FALSE(
803 installer_state.DetermineCriticalVersion(NULL, *pv_version_).IsValid()); 803 installer_state.DetermineCriticalVersion(NULL, *pv_version_).IsValid());
804 EXPECT_FALSE( 804 EXPECT_FALSE(
805 installer_state.DetermineCriticalVersion(opv_version_, *pv_version_) 805 installer_state.DetermineCriticalVersion(opv_version_, *pv_version_)
806 .IsValid()); 806 .IsValid());
807 EXPECT_FALSE( 807 EXPECT_FALSE(
808 installer_state.DetermineCriticalVersion(pv_version_, *pv_version_) 808 installer_state.DetermineCriticalVersion(pv_version_, *pv_version_)
809 .IsValid()); 809 .IsValid());
810 } 810 }
OLDNEW
« no previous file with comments | « chrome/installer/util/installer_state.cc ('k') | chrome/installer/util/move_tree_work_item_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698