Show device information in chrome://gcm-internals page.

chrome/browser/services/gcm/gcm_profile_service.h

Index: chrome/browser/services/gcm/gcm_profile_service.h
diff --git a/chrome/browser/services/gcm/gcm_profile_service.h b/chrome/browser/services/gcm/gcm_profile_service.h
index 633a6e8c7356953d3f57ef91c964a75b60e4cec7..452f326118ef784b48edb70cf4100a6e7d4451e9 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.h
+++ b/chrome/browser/services/gcm/gcm_profile_service.h
@@ -87,11 +87,17 @@ class GCMProfileService : public BrowserContextKeyedService,
                     const GCMClient::OutgoingMessage& message,
                     SendCallback callback);
 
+  // Returns true if the profile is signed in.
+  bool IsSignedIn();

[jianli, 2014/02/27 00:49:34]

nit: add const modifier

[juyik, 2014/03/01 00:21:57]

Done.

+
   // For testing purpose.
   void set_testing_delegate(TestingDelegate* testing_delegate) {
     testing_delegate_ = testing_delegate;
   }
 
+  // Returns the GCM client instance. Can be NULL. Callee owns the instance.
+  GCMClient* GetGCMClient();

[fgorski, 2014/02/26 23:38:19]

You should not expose the GCMClient that way.
Your code cares only if it is there or not.
Please use a method that checks for that and returns bool or an enum of what is
the status of the GCMClient (which could include "not created",
"not-initialized", ..., "ready" -- which obsoletes the other flag.). I think
that will be much better information than a simple boolean flag.

[jianli, 2014/02/27 00:49:34]

GCMClient is supposed to be used only in IO thread. You should not expose it for
being used in UI thread. In addition, GCMClient should not be exposed directly
and all the communication should be done thtought GCMProfileService, with
multi-threading in mind.

[juyik, 2014/03/01 00:21:57]

Done. Switch between UI and IO thread thru GCM profile service's IOWorker.

+
  protected:
   // Flag that could be set by the testing code to enable GCM. Otherwise,
   // tests from official build will fail.