Show device information in chrome://gcm-internals page.

chrome/browser/services/gcm/gcm_profile_service.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_
 #define CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_
 
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 69 matching lines @@
   // Sends a message to a given receiver.
   // |app_id|: application ID.
   // |receiver_id|: registration ID of the receiver party.
   // |message|: message to be sent.
   // |callback|: to be called once the asynchronous operation is done.
   virtual void Send(const std::string& app_id,
                     const std::string& receiver_id,
                     const GCMClient::OutgoingMessage& message,
                     SendCallback callback);
 
+  // Returns true if the profile is signed in.
+  bool IsSignedIn();

[jianli, 2014/02/27 00:49:34]

nit: add const modifier

[juyik, 2014/03/01 00:21:57]

Done.

+
   // For testing purpose.
   void set_testing_delegate(TestingDelegate* testing_delegate) {
     testing_delegate_ = testing_delegate;
   }
 
+  // Returns the GCM client instance. Can be NULL. Callee owns the instance.
+  GCMClient* GetGCMClient();

[fgorski, 2014/02/26 23:38:19]

You should not expose the GCMClient that way.
Your code cares only if it is there or not.
Please use a method that checks for that and returns bool or an enum of what is
the status of the GCMClient (which could include "not created",
"not-initialized", ..., "ready" -- which obsoletes the other flag.). I think
that will be much better information than a simple boolean flag.

[jianli, 2014/02/27 00:49:34]

GCMClient is supposed to be used only in IO thread. You should not expose it for
being used in UI thread. In addition, GCMClient should not be exposed directly
and all the communication should be done thtought GCMProfileService, with
multi-threading in mind.

[juyik, 2014/03/01 00:21:57]

Done. Switch between UI and IO thread thru GCM profile service's IOWorker.

+
  protected:
   // Flag that could be set by the testing code to enable GCM. Otherwise,
   // tests from official build will fail.
   static bool enable_gcm_for_testing_;
 
  private:
   friend class GCMProfileServiceTestConsumer;
 
   class DelayedTaskController;
   class IOWorker;
@@ skipping 112 matching lines @@
 
   // Used to pass a weak pointer to the IO worker.
   base::WeakPtrFactory<GCMProfileService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GCMProfileService);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_