Show device information in chrome://gcm-internals page.

chrome/browser/ui/webui/gcm_internals_ui.cc

Index: chrome/browser/ui/webui/gcm_internals_ui.cc
diff --git a/chrome/browser/ui/webui/gcm_internals_ui.cc b/chrome/browser/ui/webui/gcm_internals_ui.cc
index b9966204b060485cd8c46fa6164b58e255fa1523..ebf15d4efa64baf9be829879a0c86f1a6c12e71e 100644
--- a/chrome/browser/ui/webui/gcm_internals_ui.cc
+++ b/chrome/browser/ui/webui/gcm_internals_ui.cc
@@ -4,11 +4,70 @@
 
 #include "chrome/browser/ui/webui/gcm_internals_ui.h"
 
+#include "base/bind.h"
+#include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/services/gcm/gcm_profile_service.h"
+#include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
 #include "chrome/common/url_constants.h"
+#include "content/public/browser/web_ui.h"
+#include "content/public/browser/web_ui_controller.h"
 #include "content/public/browser/web_ui_data_source.h"
+#include "content/public/browser/web_ui_message_handler.h"
+#include "google_apis/gcm/gcm_client.h"
 #include "grit/browser_resources.h"
 
+namespace {
+
+// Class acting as a controller of the chrome://gcm-internals WebUI.
+class GcmInternalsUIMessageHandler : public content::WebUIMessageHandler {
+ public:
+  GcmInternalsUIMessageHandler();
+  virtual ~GcmInternalsUIMessageHandler();
+
+  // WebUIMessageHandler implementation.
+  virtual void RegisterMessages() OVERRIDE;
+
+ private:

[jianli, 2014/02/27 00:49:34]

nit: add DISALLOW_COPY_AND_ASSIGN

[juyik, 2014/03/01 00:21:57]

Done.

+  // Gets all of the GCM related infos and returns them to the caller using
+  // Javascript callback function
+  // |gcm-internals.returnInfo()|.
+  void GetAllInfo(const base::ListValue* args);

[jianli, 2014/02/27 00:49:34]

nit: add const modifier

[juyik, 2014/03/01 00:21:57]

Done.

+};
+
+GcmInternalsUIMessageHandler::GcmInternalsUIMessageHandler() {}
+
+GcmInternalsUIMessageHandler::~GcmInternalsUIMessageHandler() {}
+
+void GcmInternalsUIMessageHandler::GetAllInfo(const base::ListValue* args) {
+  base::DictionaryValue results;
+  base::DictionaryValue* device_info = new base::DictionaryValue();
+
+  Profile* profile = Profile::FromWebUI(web_ui());
+  gcm::GCMProfileService* profile_service =

[jianli, 2014/02/27 00:49:34]

profile_service could be null, like in incognito mode.

[juyik, 2014/03/01 00:21:57]

Done.

+      gcm::GCMProfileServiceFactory::GetForProfile(profile);
+  gcm::GCMClient* gcm_client = profile_service->GetGCMClient();
+
+  device_info->SetBoolean("gcmEnabled",
+                          gcm::GCMProfileService::IsGCMEnabled(profile));
+  device_info->SetBoolean("userSignedIn", profile_service->IsSignedIn());

[fgorski, 2014/02/26 23:38:19]

this is duplicated.

[juyik, 2014/03/01 00:21:57]

Done.

+  device_info->SetBoolean("userSignedIn", profile_service->IsSignedIn());
+  device_info->SetBoolean("gcmClientCreated", gcm_client != NULL);
+  if (gcm_client)
+    device_info->SetBoolean("gcmClientReady", gcm_client->IsReady());

[jianli, 2014/02/27 00:49:34]

IsReady is going to be removed from GCMClient interface and you should access
something on GCMClient directly. To find out if GCMClient is ready, you can get
it from GCMProfileService::gcm_client_ready_.

[juyik, 2014/03/01 00:21:57]

Done.

+
+  results.Set("deviceInfo", device_info);
+  web_ui()->CallJavascriptFunction("gcm_internals.returnInfos", results);
+}
+
+void GcmInternalsUIMessageHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback("gcmInternalsGetInfo",

[fgorski, 2014/02/26 23:38:19]

call it getGcmInternalsInfo 

[juyik, 2014/03/01 00:21:57]

Done.

+      base::Bind(&GcmInternalsUIMessageHandler::GetAllInfo,
+                 base::Unretained(this)));
+}
+
+}  // namespace
+
 GCMInternalsUI::GCMInternalsUI(content::WebUI* web_ui)
     : content::WebUIController(web_ui) {
   // Set up the chrome://gcm-internals source.
@@ -25,6 +84,8 @@ GCMInternalsUI::GCMInternalsUI(content::WebUI* web_ui)
 
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource::Add(profile, html_source);
+
+  web_ui->AddMessageHandler(new GcmInternalsUIMessageHandler());
 }
 
 GCMInternalsUI::~GCMInternalsUI() {}