Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1767573002: In mapAncestorToLocal, account for frame documents always being fixed-position containers. (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In mapAncestorToLocal, account for frame documents always being fixed-position containers. BUG=591174 Committed: https://crrev.com/37ca7fe6f5baa7074524c9754010aa3f425cced8 Cr-Commit-Position: refs/heads/master@{#379229}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +3 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
chrishtr
4 years, 9 months ago (2016-03-04 05:02:08 UTC) #5
Xianzhu
lgtm
4 years, 9 months ago (2016-03-04 05:21:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767573002/1
4 years, 9 months ago (2016-03-04 05:24:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 06:32:13 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/37ca7fe6f5baa7074524c9754010aa3f425cced8 Cr-Commit-Position: refs/heads/master@{#379229}
4 years, 9 months ago (2016-03-04 06:33:42 UTC) #12
szager1
https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/core/layout/LayoutView.cpp File third_party/WebKit/Source/core/layout/LayoutView.cpp (right): https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/core/layout/LayoutView.cpp#newcode409 third_party/WebKit/Source/core/layout/LayoutView.cpp:409: mode &= !IsFixed; Shouldn't this be: mode &= ~IsFixed; ...
4 years, 9 months ago (2016-03-04 07:41:05 UTC) #13
chrishtr
4 years, 9 months ago (2016-03-04 18:39:27 UTC) #14
Message was sent while issue was closed.
On 2016/03/04 at 07:41:05, szager wrote:
>
https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):
> 
>
https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutView.cpp:409: mode &= !IsFixed;
> Shouldn't this be:
> 
> mode &= ~IsFixed;
> 
> ?

Indeed, fixing now.

Powered by Google App Engine
This is Rietveld 408576698