In mapAncestorToLocal, account for frame documents always being fixed-position containers.

In mapAncestorToLocal, account for frame documents always being fixed-position containers.

BUG=591174
Committed: https://crrev.com/37ca7fe6f5baa7074524c9754010aa3f425cced8
Cr-Commit-Position: refs/heads/master@{#379229}

[chrishtr, 2016-03-04 05:00:55]

Description was changed from

==========
none


none

BUG=
==========

to

==========
In ancestorToLocalPoint, account for frame documents always being fixed-position
containers.

BUG=
==========

[chrishtr, 2016-03-04 05:01:08]

Description was changed from

==========
In ancestorToLocalPoint, account for frame documents always being fixed-position
containers.

BUG=
==========

to

==========
In mapAncestorToLocal, account for frame documents always being fixed-position
containers.

BUG=
==========

[chrishtr, 2016-03-04 05:01:52]

Description was changed from

==========
In mapAncestorToLocal, account for frame documents always being fixed-position
containers.

BUG=
==========

to

==========
In mapAncestorToLocal, account for frame documents always being fixed-position
containers.

BUG=591174
==========

[chrishtr, 2016-03-04 05:02:08]

chrishtr@chromium.org changed reviewers:
+ leviw@chromium.org, szager@chromium.org

[Xianzhu, 2016-03-04 05:21:30]

wangxianzhu@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-03-04 05:21:30]

lgtm

[chrishtr, 2016-03-04 05:24:23]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-03-04 05:24:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767573002/1

[commit-bot: I haz the power, 2016-03-04 06:32:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-04 06:33:41]

Description was changed from

==========
In mapAncestorToLocal, account for frame documents always being fixed-position
containers.

BUG=591174
==========

to

==========
In mapAncestorToLocal, account for frame documents always being fixed-position
containers.

BUG=591174

Committed: https://crrev.com/37ca7fe6f5baa7074524c9754010aa3f425cced8
Cr-Commit-Position: refs/heads/master@{#379229}
==========

[commit-bot: I haz the power, 2016-03-04 06:33:42]

Patchset 1 (id:??) landed as
https://crrev.com/37ca7fe6f5baa7074524c9754010aa3f425cced8
Cr-Commit-Position: refs/heads/master@{#379229}

[szager1, 2016-03-04 07:41:05]

https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):

https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutView.cpp:409: mode &= !IsFixed;
Shouldn't this be:

mode &= ~IsFixed;

?

[chrishtr, 2016-03-04 18:39:27]

On 2016/03/04 at 07:41:05, szager wrote:
>
https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):
> 
>
https://codereview.chromium.org/1767573002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutView.cpp:409: mode &= !IsFixed;
> Shouldn't this be:
> 
> mode &= ~IsFixed;
> 
> ?

Indeed, fixing now.