Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1767573002: In mapAncestorToLocal, account for frame documents always being fixed-position containers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutView.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp
index 5da123b695f693d7e53dedbd6546c97f8156820b..632261ac2556e30c2672fc7851418f87d4541e4f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp
@@ -405,6 +405,9 @@ void LayoutView::mapAncestorToLocal(const LayoutBoxModelObject* ancestor, Transf
if (mode & TraverseDocumentBoundaries) {
if (LayoutPart* parentDocLayoutObject = frame()->ownerLayoutObject()) {
+ // A LayoutView is a containing block for fixed-position elements, so don't carry this state across frames.
+ mode &= !IsFixed;
szager1 2016/03/04 07:41:05 Shouldn't this be: mode &= ~IsFixed; ?
+
parentDocLayoutObject->mapAncestorToLocal(ancestor, transformState, mode);
transformState.move(parentDocLayoutObject->contentBoxOffset());
transformState.move(-frame()->view()->scrollOffset());
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698