Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1767573002: In mapAncestorToLocal, account for frame documents always being fixed-position containers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 transformState.move(toIntSize(m_frameView->scrollPosition())); 398 transformState.move(toIntSize(m_frameView->scrollPosition()));
399 399
400 if (mode & UseTransforms && shouldUseTransformFromContainer(0)) { 400 if (mode & UseTransforms && shouldUseTransformFromContainer(0)) {
401 TransformationMatrix t; 401 TransformationMatrix t;
402 getTransformFromContainer(0, LayoutSize(), t); 402 getTransformFromContainer(0, LayoutSize(), t);
403 transformState.applyTransform(t); 403 transformState.applyTransform(t);
404 } 404 }
405 405
406 if (mode & TraverseDocumentBoundaries) { 406 if (mode & TraverseDocumentBoundaries) {
407 if (LayoutPart* parentDocLayoutObject = frame()->ownerLayoutObject()) { 407 if (LayoutPart* parentDocLayoutObject = frame()->ownerLayoutObject()) {
408 // A LayoutView is a containing block for fixed-position elements, s o don't carry this state across frames.
409 mode &= !IsFixed;
szager1 2016/03/04 07:41:05 Shouldn't this be: mode &= ~IsFixed; ?
410
408 parentDocLayoutObject->mapAncestorToLocal(ancestor, transformState, mode); 411 parentDocLayoutObject->mapAncestorToLocal(ancestor, transformState, mode);
409 transformState.move(parentDocLayoutObject->contentBoxOffset()); 412 transformState.move(parentDocLayoutObject->contentBoxOffset());
410 transformState.move(-frame()->view()->scrollOffset()); 413 transformState.move(-frame()->view()->scrollOffset());
411 } 414 }
412 } else { 415 } else {
413 ASSERT(!ancestor); 416 ASSERT(!ancestor);
414 } 417 }
415 } 418 }
416 419
417 void LayoutView::computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layout Point&) const 420 void LayoutView::computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layout Point&) const
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
1016 if (!document().ownerElement()) 1019 if (!document().ownerElement())
1017 setHasBoxDecorationBackground(true); 1020 setHasBoxDecorationBackground(true);
1018 } 1021 }
1019 1022
1020 bool LayoutView::allowsOverflowClip() const 1023 bool LayoutView::allowsOverflowClip() const
1021 { 1024 {
1022 return document().settings() && document().settings()->rootLayerScrolls(); 1025 return document().settings() && document().settings()->rootLayerScrolls();
1023 } 1026 }
1024 1027
1025 } // namespace blink 1028 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698