Insert panel icons on the left of other panel icons.

Insert panel icons on the left of other panel icons.

BUG=253648
TEST=ChromeLauncherControllerPerAppTest.AppPanels
TEST=Open hangouts, open chat windows, chats open to the left of existing panels.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208626

[flackr, 2013-06-25 15:27:24]

There's two ways I can see of having panels inserted on the left: changing the
layout in launcher_view and maintaining the current model order or changing the
order they're inserted in launcher_model. I think maintaining the left to right
(text direction) order of items in the launcher model is probably safer so that
we don't break any assumptions about the layout order. PTAL, thanks.

[sky, 2013-06-25 16:19:45]

https://codereview.chromium.org/17673004/diff/4001/ash/launcher/launcher_mode...
File ash/launcher/launcher_model.cc (right):

https://codereview.chromium.org/17673004/diff/4001/ash/launcher/launcher_mode...
ash/launcher/launcher_model.cc:59: if (index == kAutomaticIndex)
Can we move this magic to where we create panel items?

[flackr, 2013-06-25 17:40:52]

https://codereview.chromium.org/17673004/diff/4001/ash/launcher/launcher_mode...
File ash/launcher/launcher_model.cc (right):

https://codereview.chromium.org/17673004/diff/4001/ash/launcher/launcher_mode...
ash/launcher/launcher_model.cc:59: if (index == kAutomaticIndex)
On 2013/06/25 16:19:45, sky wrote:
> Can we move this magic to where we create panel items?

Sure, done.

[sky, 2013-06-25 17:54:16]

LGTM

[commit-bot: I haz the power, 2013-06-25 20:02:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/17673004/10001

[flackr, 2013-06-25 21:26:40]

Sorry, I realized we should be doing this check on the launcher per browser
controller as well, even though this is probably going away and is currently
behind a flag.

[sky, 2013-06-25 21:29:15]

LGTM

[commit-bot: I haz the power, 2013-06-25 23:05:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/17673004/31001

[commit-bot: I haz the power, 2013-06-26 00:15:33]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-06-26 01:39:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/17673004/31001

[commit-bot: I haz the power, 2013-06-26 04:32:45]

Change committed as 208626