chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc - Issue 17673004: Insert panel icons on the left of other panel icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

Issue 17673004: Insert panel icons on the left of other panel icons. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add condition to per browser launcher controller as well. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

index 1bc7d3543a16d575a4f7f770cf64bc10f59cbaa4..34bddec38112fa72f9479dfea68cce55b77dd888 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

@@ -383,8 +383,10 @@ ash::LauncherID ChromeLauncherControllerPerBrowser::CreateAppLauncherItem(

const std::string& app_id,

ash::LauncherItemStatus status) {

DCHECK(controller);

- return InsertAppLauncherItem(controller, app_id, status,

- model_->item_count());

+ // Panels are inserted on the left so as not to push all existing panels over.

+ int index = controller->GetLauncherItemType() == ash::TYPE_APP_PANEL ?

+ 0 : model_->item_count();

+ return InsertAppLauncherItem(controller, app_id, status, index);

}

void ChromeLauncherControllerPerBrowser::SetItemStatus(

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc ('k') | no next file » | no next file with comments »