Add DCHECK for primary_url and secondary_url in HostContentSettingsMap::GetPatternsFromScopingType

Add DCHECK for primary_url and secondary_url in HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty when
generating patterns.

Also assigns an url to download unit tests.

BUG=551747
Committed: https://crrev.com/41052729d42a2d5486191139dc73865f86e11810
Cr-Commit-Position: refs/heads/master@{#382448}

[lshang, 2016-03-14 02:49:10]

Patchset #4 (id:60001) has been deleted

[lshang, 2016-03-14 02:49:18]

Patchset #3 (id:40001) has been deleted

[lshang, 2016-03-14 02:49:32]

Patchset #3 (id:80001) has been deleted

[lshang, 2016-03-14 03:15:21]

Description was changed from

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

BUG=
==========

to

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty.

Also assigns an url to download unit tests. 

BUG=551747
==========

[lshang, 2016-03-14 03:15:49]

Description was changed from

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty.

Also assigns an url to download unit tests. 

BUG=551747
==========

to

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty when
generating patterns.

Also assigns an url to download unit tests. 

BUG=551747
==========

[lshang, 2016-03-14 03:17:39]

lshang@chromium.org changed reviewers:
+ dominickn@chromium.org, raymes@chromium.org

[lshang, 2016-03-14 03:17:39]

PTAL thanks!

[raymes, 2016-03-14 03:35:09]

content_settings lgtm

[dominickn, 2016-03-14 04:02:44]

DRL (non-owner) lgtm with nits.

https://codereview.chromium.org/1767083004/diff/100001/chrome/browser/downloa...
File chrome/browser/download/download_request_limiter_unittest.cc (right):

https://codereview.chromium.org/1767083004/diff/100001/chrome/browser/downloa...
chrome/browser/download/download_request_limiter_unittest.cc:467: // To make
sure that url is not empty.
Nit: I don't think this comment is needed.

https://codereview.chromium.org/1767083004/diff/100001/chrome/browser/downloa...
chrome/browser/download/download_request_limiter_unittest.cc:469:
web_contents.get()->GetController().LoadURL(
Nit: I think this can just be web_contents->GetController().LoadURL(.....

[lshang, 2016-03-16 02:42:15]

lshang@chromium.org changed reviewers:
+ asanka@chromium.org

[lshang, 2016-03-16 02:42:16]

+asanka for OWNER approval of chrome/browser/download/

https://codereview.chromium.org/1767083004/diff/100001/chrome/browser/downloa...
File chrome/browser/download/download_request_limiter_unittest.cc (right):

https://codereview.chromium.org/1767083004/diff/100001/chrome/browser/downloa...
chrome/browser/download/download_request_limiter_unittest.cc:467: // To make
sure that url is not empty.
On 2016/03/14 04:02:44, dominickn wrote:
> Nit: I don't think this comment is needed.

Done.

https://codereview.chromium.org/1767083004/diff/100001/chrome/browser/downloa...
chrome/browser/download/download_request_limiter_unittest.cc:469:
web_contents.get()->GetController().LoadURL(
On 2016/03/14 04:02:44, dominickn wrote:
> Nit: I think this can just be web_contents->GetController().LoadURL(.....

Done.

[lshang, 2016-03-20 23:15:42]

@asanka, kindly ping:-)

[asanka, 2016-03-21 19:59:31]

lgtm

[lshang, 2016-03-21 22:46:47]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-03-21 22:46:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1767083004/#ps140001
(title: "address review comments")

[commit-bot: I haz the power, 2016-03-21 22:47:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767083004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767083004/140001

[commit-bot: I haz the power, 2016-03-22 00:08:09]

Description was changed from

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty when
generating patterns.

Also assigns an url to download unit tests. 

BUG=551747
==========

to

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty when
generating patterns.

Also assigns an url to download unit tests. 

BUG=551747
==========

[commit-bot: I haz the power, 2016-03-22 00:08:10]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-03-22 00:09:31]

Description was changed from

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty when
generating patterns.

Also assigns an url to download unit tests. 

BUG=551747
==========

to

==========
Add DCHECK for primary_url and secondary_url in
HostContentSettingsMap::GetPatternsFromScopingType

Add checks to ensure that primary_url or secondary_url is not empty when
generating patterns.

Also assigns an url to download unit tests.

BUG=551747

Committed: https://crrev.com/41052729d42a2d5486191139dc73865f86e11810
Cr-Commit-Position: refs/heads/master@{#382448}
==========

[commit-bot: I haz the power, 2016-03-22 00:09:33]

Patchset 5 (id:??) landed as
https://crrev.com/41052729d42a2d5486191139dc73865f86e11810
Cr-Commit-Position: refs/heads/master@{#382448}