Add DCHECK for primary_url and secondary_url in HostContentSettingsMap::GetPatternsFromScopingType

chrome/browser/download/download_request_limiter_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_request_limiter.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "build/build_config.h"
@@ skipping 235 matching lines @@
   int cancel_count_;
 
   scoped_refptr<HostContentSettingsMap> content_settings_;
   TestingDelegate testing_delegate_;
 
  private:
   scoped_ptr<TestingProfile> profile_;
 };
 
 TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_Allow) {
+  NavigateAndCommit(GURL("http://foo.com/bar"));
   LoadCompleted();
 
   // All tabs should initially start at ALLOW_ONE_DOWNLOAD.
   ASSERT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 
   // Ask if the tab can do a download. This moves to PROMPT_BEFORE_DOWNLOAD.
   CanDownload();
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
@@ skipping 190 matching lines @@
   CanDownload();
   ExpectAndResetCounts(0, 1, 0, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 }
 
 #if defined(OS_ANDROID)
 TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_RawWebContents) {
   scoped_ptr<WebContents> web_contents(CreateTestWebContents());
 
+  // To make sure that url is not empty.

[dominickn, 2016/03/14 04:02:44]

Nit: I don't think this comment is needed.

[lshang, 2016/03/16 02:42:16]

Done.

+  GURL url("http://foo.com/bar");
+  web_contents.get()->GetController().LoadURL(

[dominickn, 2016/03/14 04:02:44]

Nit: I think this can just be web_contents->GetController().LoadURL(.....

[lshang, 2016/03/16 02:42:16]

Done.

+      url, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
+
   // DownloadRequestLimiter won't try to make a permission bubble if there's
   // no permission bubble manager, so don't put one on the test WebContents.
 
   // DownloadRequestLimiter won't try to make an infobar if it doesn't have an
   // InfoBarService, and we want to test that it will Cancel() instead of
   // prompting when it doesn't have a InfoBarService, so unset the delegate.
   testing_delegate_.UnsetInfobarDelegate();
   ExpectAndResetCounts(0, 0, 0, __LINE__);
   EXPECT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
@@ skipping 101 matching lines @@
   // changing the content setting).
   UpdateContentSettings(web_contents(), CONTENT_SETTING_ASK);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
   UpdateExpectations(WAIT);
   CanDownload();
   ExpectAndResetCounts(0, 0, 1, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 }