Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 1767083004: Add DCHECK for primary_url and secondary_url in HostContentSettingsMap::GetPatternsFromScopingType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_request_limiter_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/browser/host_content_settings_map.cc
diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc
index d1151eab85af2a51fa622b979cda1d05674ff2a3..02ec6d58d8839806d00cccecf4f37a7d9324f86b 100644
--- a/components/content_settings/core/browser/host_content_settings_map.cc
+++ b/components/content_settings/core/browser/host_content_settings_map.cc
@@ -112,6 +112,7 @@ content_settings::PatternPair GetPatternsFromScopingType(
WebsiteSettingsInfo::ScopingType scoping_type,
const GURL& primary_url,
const GURL& secondary_url) {
+ DCHECK(!primary_url.is_empty());
content_settings::PatternPair patterns;
switch (scoping_type) {
@@ -125,6 +126,7 @@ content_settings::PatternPair GetPatternsFromScopingType(
patterns.second = ContentSettingsPattern::Wildcard();
break;
case WebsiteSettingsInfo::REQUESTING_ORIGIN_AND_TOP_LEVEL_ORIGIN_SCOPE:
+ DCHECK(!secondary_url.is_empty());
patterns.first = ContentSettingsPattern::FromURLNoWildcard(primary_url);
patterns.second =
ContentSettingsPattern::FromURLNoWildcard(secondary_url);
« no previous file with comments | « chrome/browser/download/download_request_limiter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698