scripts/slave/recipes/findit/chromium/compile.py - Issue 1766873002: Collect failed "target"s from ninja in the compile step on Waterfall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 1766873002: Collect failed "target"s from ninja in the compile step on Waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@check_target_existence

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/api.py ('k') | scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/findit/chromium/compile.py

diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py

index ac64257cf7936ba527d8380e8760ecc3621ace2e..58bcc8d98d9062cef74547547560b3db4b555c6b 100644

--- a/scripts/slave/recipes/findit/chromium/compile.py

+++ b/scripts/slave/recipes/findit/chromium/compile.py

@@ -320,7 +320,25 @@ def GenTests(api):

yield (

api.test('compile_failed') +

props() +

- api.override_step_data('test r1.compile', retcode=1)

+ api.override_step_data(

+ 'test r1.compile',

+ api.json.output({

+ 'notice': [

+ {

+ 'infra_status': {

+ 'ping_status_code': 200,

+ },

+ ],

+ }),

+ api.json.output({

+ 'failed_targets': [

+ 'obj/path/to/file.o',

+ ],

+ 'unknown_targets': [],

+ 'unrecognized_format': False,

+ }, name='ninja-compile-failure'),

+ retcode=1)

)

yield (