Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json

Issue 1766873002: Collect failed "target"s from ninja in the compile step on Waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@check_target_existence
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/findit/chromium/compile.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
diff --git a/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json b/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
index dff031e7c93696a4d4354b50b0dff637117cceed..5c95219b22b02f7634b8b2b7fad1ea8a59499fe2 100644
--- a/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
+++ b/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
@@ -398,6 +398,8 @@
"[GOMA_CACHE]",
"--build-tool",
"ninja",
+ "--ninja-compile-failure",
+ "/path/to/tmp/json",
"--compiler",
"goma",
"--goma-jsonstatus",
@@ -413,11 +415,18 @@
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"step returned non-zero exit code: 1",
- "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
- "@@@STEP_LOG_END@json.output (invalid)@@@",
- "@@@STEP_LOG_LINE@exception@TypeError(\"'NoneType' object has no attribute '__getitem__'\",)@@@",
- "@@@STEP_LOG_END@exception@@@",
- "@@@STEP_WARNINGS@@@"
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"notice\": [@@@",
+ "@@@STEP_LOG_LINE@json.output@ {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"infra_status\": {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"ping_status_code\": 200@@@",
+ "@@@STEP_LOG_LINE@json.output@ }@@@",
+ "@@@STEP_LOG_LINE@json.output@ }@@@",
+ "@@@STEP_LOG_LINE@json.output@ ]@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@STEP_FAILURE@@@",
+ "@@@SET_BUILD_PROPERTY@compile_failures@{\"failed_targets\": [\"obj/path/to/file.o\"], \"unknown_targets\": [], \"unrecognized_format\": false}@@@"
]
},
{
« no previous file with comments | « scripts/slave/recipes/findit/chromium/compile.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698