Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 1766873002: Collect failed "target"s from ninja in the compile step on Waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@check_target_existence
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 6
7 from recipe_engine.config import List 7 from recipe_engine.config import List
8 from recipe_engine.config import Single 8 from recipe_engine.config import Single
9 from recipe_engine.recipe_api import Property 9 from recipe_engine.recipe_api import Property
10 10
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 313
314 yield ( 314 yield (
315 api.test('compile_succeeded') + 315 api.test('compile_succeeded') +
316 props() + 316 props() +
317 api.override_step_data('test r1.compile', retcode=0) 317 api.override_step_data('test r1.compile', retcode=0)
318 ) 318 )
319 319
320 yield ( 320 yield (
321 api.test('compile_failed') + 321 api.test('compile_failed') +
322 props() + 322 props() +
323 api.override_step_data('test r1.compile', retcode=1) 323 api.override_step_data(
324 'test r1.compile',
325 api.json.output({
326 'notice': [
327 {
328 'infra_status': {
329 'ping_status_code': 200,
330 },
331 },
332 ],
333 }),
334 api.json.output({
335 'failed_targets': [
336 'obj/path/to/file.o',
337 ],
338 'unknown_targets': [],
339 'unrecognized_format': False,
340 }, name='ninja-compile-failure'),
341 retcode=1)
324 ) 342 )
325 343
326 yield ( 344 yield (
327 api.test('failed_compile_upon_infra_failure_goma_setup_failure') + 345 api.test('failed_compile_upon_infra_failure_goma_setup_failure') +
328 props(compile_targets=['target_name']) + 346 props(compile_targets=['target_name']) +
329 api.override_step_data('test r1.check_targets', 347 api.override_step_data('test r1.check_targets',
330 api.json.output({ 348 api.json.output({
331 'found': ['target_name'], 349 'found': ['target_name'],
332 'not_found': [], 350 'not_found': [],
333 })) + 351 })) +
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 'git commits in range', 548 'git commits in range',
531 api.raw_io.stream_output( 549 api.raw_io.stream_output(
532 '\n'.join('r%d' % i for i in reversed(range(2, 6))))) + 550 '\n'.join('r%d' % i for i in reversed(range(2, 6))))) +
533 api.override_step_data('test r2.check_targets', 551 api.override_step_data('test r2.check_targets',
534 api.json.output({ 552 api.json.output({
535 'found': ['target_name'], 553 'found': ['target_name'],
536 'not_found': [], 554 'not_found': [],
537 })) + 555 })) +
538 api.override_step_data('test r2.compile', retcode=1) 556 api.override_step_data('test r2.compile', retcode=1)
539 ) 557 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698