Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1766723003: revise unittest for annotations in preparation for skia change (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

revise unittest for annotations in preparation for skia change See skia change https://codereview.chromium.org/1758023003 BUG= Committed: https://crrev.com/7d95209934da45b7f82a5e2f88d150c9429c0267 Cr-Commit-Position: refs/heads/master@{#379399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
reed1
4 years, 9 months ago (2016-03-04 22:31:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766723003/1
4 years, 9 months ago (2016-03-04 22:31:50 UTC) #4
f(malita)
lgtm
4 years, 9 months ago (2016-03-04 22:33:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766723003/1
4 years, 9 months ago (2016-03-04 22:35:33 UTC) #8
hal.canary
lgtm my code is bad and I should feel bad
4 years, 9 months ago (2016-03-04 22:40:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 23:46:46 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 23:48:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d95209934da45b7f82a5e2f88d150c9429c0267
Cr-Commit-Position: refs/heads/master@{#379399}

Powered by Google App Engine
This is Rietveld 408576698