Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758023003: Move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/174410… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
hal.canary, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add SK_SUPPORT_NEW_ANNOTATION_CANVAS_VIRTUAL flag for chrome's PrintContextTest.cpp #

Patch Set 3 : #

Patch Set 4 : manual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -253 lines) Patch
M include/core/SkAnnotation.h View 1 5 chunks +7 lines, -73 lines 0 comments Download
M include/core/SkCanvas.h View 3 chunks +14 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 3 chunks +0 lines, -5 lines 0 comments Download
M include/core/SkPicture.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/core/SkWriter32.h View 1 chunk +12 lines, -0 lines 0 comments Download
M include/private/SkRecords.h View 4 chunks +8 lines, -2 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/core/SkAnnotation.cpp View 2 chunks +8 lines, -47 lines 0 comments Download
A src/core/SkAnnotationKeys.h View 1 chunk +33 lines, -0 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 14 chunks +9 lines, -30 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkReader32.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkRemote.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkRemote.cpp View 10 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkRemote_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 8 chunks +0 lines, -12 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 7 chunks +31 lines, -49 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/SerializationTest.cpp View 2 chunks +83 lines, -0 lines 0 comments Download
M tests/Writer32Test.cpp View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758023003/20001
4 years, 9 months ago (2016-03-04 21:24:40 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 21:40:38 UTC) #5
reed1
4 years, 9 months ago (2016-03-04 22:33:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758023003/40001
4 years, 9 months ago (2016-03-04 23:51:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/931) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 9 months ago (2016-03-04 23:53:34 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758023003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758023003/60001
4 years, 9 months ago (2016-03-05 00:19:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758023003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758023003/60001
4 years, 9 months ago (2016-03-05 00:23:29 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 00:36:25 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f70b531daaf47db1ee95c70da9843f1dd1f418d3

Powered by Google App Engine
This is Rietveld 408576698