Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1770553002: Simplify createCrossThreadTask() (Closed)

Created:
4 years, 9 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
Yuta Kitamura, tzik
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Mikhail, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_EC5_CleanupCrossThreadAccess
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify createCrossThreadTask() BUG=597856 Committed: https://crrev.com/65db3fe5a8ebb20beb15d43fcfd8fea419a096e6 Cr-Commit-Position: refs/heads/master@{#394117}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Simpler #

Patch Set 4 : #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Patch Set 10 : auto-Rebase #

Patch Set 11 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -65 lines) Patch
M third_party/WebKit/Source/core/dom/CrossThreadTask.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContextTask.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +29 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 50 (25 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/20001
4 years, 9 months ago (2016-03-05 02:18:14 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/184601)
4 years, 9 months ago (2016-03-05 04:16:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/40001
4 years, 9 months ago (2016-03-07 18:11:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/120001
4 years, 8 months ago (2016-04-22 11:23:20 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/215878)
4 years, 8 months ago (2016-04-22 12:23:29 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/140001
4 years, 8 months ago (2016-04-22 12:31:01 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 14:04:43 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/160001
4 years, 8 months ago (2016-04-27 06:30:45 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-27 08:15:44 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/180001
4 years, 8 months ago (2016-04-27 09:27:35 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-27 11:21:53 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/200001
4 years, 7 months ago (2016-05-13 06:45:01 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 08:24:32 UTC) #28
hiroshige
PTAL.
4 years, 7 months ago (2016-05-13 08:25:58 UTC) #30
tzik
lgtm
4 years, 7 months ago (2016-05-16 02:34:27 UTC) #31
Yuta Kitamura
lgtm
4 years, 7 months ago (2016-05-16 04:40:32 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/200001
4 years, 7 months ago (2016-05-17 00:15:54 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/222702)
4 years, 7 months ago (2016-05-17 04:56:59 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/200001
4 years, 7 months ago (2016-05-17 05:27:56 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/222875)
4 years, 7 months ago (2016-05-17 10:41:25 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/200001
4 years, 7 months ago (2016-05-17 11:06:19 UTC) #42
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 12:57:02 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770553002/200001
4 years, 7 months ago (2016-05-17 14:08:26 UTC) #46
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 7 months ago (2016-05-17 14:11:34 UTC) #48
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 14:12:45 UTC) #50
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/65db3fe5a8ebb20beb15d43fcfd8fea419a096e6
Cr-Commit-Position: refs/heads/master@{#394117}

Powered by Google App Engine
This is Rietveld 408576698