Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1766023002: [Extensions UI Views] Adjust the wrench menu actions for items added/removed (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Views] Adjust the wrench menu actions for items added/removed Extension items can be added or removed to the wrench menu while it is open (if, for instance, a popup closes and slides the item back in, or, more rarely, the extension is only just added, crashes, etc). In rare cases, this can result in the container needing to add or remove a row, which means the rest of the menu's height needs to adjust. BUG=591028 Review URL: https://codereview.chromium.org/1757993003 Cr-Commit-Position: refs/heads/master@{#379035} (cherry picked from commit f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b) Committed: https://chromium.googlesource.com/chromium/src/+/94da142c673729d277c271134754d82677eefa93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 9 months ago (2016-03-04 20:11:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94da142c673729d277c271134754d82677eefa93.

Powered by Google App Engine
This is Rietveld 408576698