[Extensions UI Views] Adjust the wrench menu actions for items added/removed

[Extensions UI Views] Adjust the wrench menu actions for items added/removed

Extension items can be added or removed to the wrench menu while it is open
(if, for instance, a popup closes and slides the item back in, or, more rarely,
the extension is only just added, crashes, etc). In rare cases, this can result
in the container needing to add or remove a row, which means the rest of the
menu's height needs to adjust.

BUG=591028
Committed: https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b
Cr-Commit-Position: refs/heads/master@{#379035}

[Devlin, 2016-03-02 22:45:55]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org

[Devlin, 2016-03-02 22:45:56]

Scott, mind taking a look?

https://codereview.chromium.org/1757993003/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (left):

https://codereview.chromium.org/1757993003/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:129:
parent()->parent()->Layout();
This wasn't enough - it redrew all the menu items, but not the menu itself, so
some items could be pushed off.

[sky, 2016-03-03 00:33:15]

https://codereview.chromium.org/1757993003/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (right):

https://codereview.chromium.org/1757993003/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:137:
menu_item_->GetParentMenuItem()->GetSubmenu()->set_resize_open_menu(false);
MenuController::MenuChildrenChanged is intended to handle this case.

[Devlin, 2016-03-03 01:46:24]

https://codereview.chromium.org/1757993003/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (right):

https://codereview.chromium.org/1757993003/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:137:
menu_item_->GetParentMenuItem()->GetSubmenu()->set_resize_open_menu(false);
On 2016/03/03 00:33:15, sky wrote:
> MenuController::MenuChildrenChanged is intended to handle this case.

Ah, much nicer.  Using that now.

[sky, 2016-03-03 04:31:29]

LGTM

[Devlin, 2016-03-03 16:56:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-03 16:56:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757993003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757993003/20001

[commit-bot: I haz the power, 2016-03-03 18:00:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 18:01:40]

Description was changed from

==========
[Extensions UI Views] Adjust the wrench menu actions for items added/removed

Extension items can be added or removed to the wrench menu while it is open
(if, for instance, a popup closes and slides the item back in, or, more rarely,
the extension is only just added, crashes, etc). In rare cases, this can result
in the container needing to add or remove a row, which means the rest of the
menu's height needs to adjust.

BUG=591028
==========

to

==========
[Extensions UI Views] Adjust the wrench menu actions for items added/removed

Extension items can be added or removed to the wrench menu while it is open
(if, for instance, a popup closes and slides the item back in, or, more rarely,
the extension is only just added, crashes, etc). In rare cases, this can result
in the container needing to add or remove a row, which means the rest of the
menu's height needs to adjust.

BUG=591028

Committed: https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b
Cr-Commit-Position: refs/heads/master@{#379035}
==========

[commit-bot: I haz the power, 2016-03-03 18:01:41]

Patchset 2 (id:??) landed as
https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b
Cr-Commit-Position: refs/heads/master@{#379035}