Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc

Issue 1766023002: [Extensions UI Views] Adjust the wrench menu actions for items added/removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
diff --git a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
index 0232e6c2544b2a32f9d4e0b00760f2d9ccaa9799..659c61e63fcd381424cac2fd010e3473092f1be6 100644
--- a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
+++ b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
@@ -24,10 +24,13 @@ namespace {
int g_close_menu_delay = 300;
}
-ExtensionToolbarMenuView::ExtensionToolbarMenuView(Browser* browser,
- AppMenu* app_menu)
+ExtensionToolbarMenuView::ExtensionToolbarMenuView(
+ Browser* browser,
+ AppMenu* app_menu,
+ views::MenuItemView* menu_item)
: browser_(browser),
app_menu_(app_menu),
+ menu_item_(menu_item),
container_(nullptr),
max_height_(0),
toolbar_actions_bar_observer_(this),
@@ -124,12 +127,12 @@ void ExtensionToolbarMenuView::CloseAppMenu() {
void ExtensionToolbarMenuView::Redraw() {
// In a case where the size of the container may have changed (e.g., by a row
// being added or removed), we need to re-layout the menu in order to resize
- // the view (calling Layout() on this is insufficient because other items may
- // need to shift up or down).
- parent()->parent()->Layout();
- // The Menus layout code doesn't recursively call layout on its children like
- // the default View code. Explicitly layout this view.
+ // the view. This may result in redrawing the window. Luckily, this happens
+ // only in the case of a row being aded or removed (very rare), and
+ // typically happens near menu initialization (rather than once the menu is
+ // fully open).
Layout();
+ menu_item_->GetParentMenuItem()->ChildrenChanged();
}
int ExtensionToolbarMenuView::start_padding() const {
« no previous file with comments | « chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698