Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1765523002: Add a cache of GrVkSamplers in GrVkResourceProvider. (Closed)

Created:
4 years, 9 months ago by egdaniel
Modified:
4 years, 9 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -12 lines) Patch
M src/gpu/vk/GrVkProgram.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkProgram.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.cpp View 1 2 3 4 chunks +27 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkSampler.h View 1 chunk +11 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkSampler.cpp View 3 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
egdaniel
4 years, 9 months ago (2016-03-03 18:11:33 UTC) #3
jvanverth1
lgtm + nits https://codereview.chromium.org/1765523002/diff/40001/src/gpu/vk/GrVkResourceProvider.cpp File src/gpu/vk/GrVkResourceProvider.cpp (right): https://codereview.chromium.org/1765523002/diff/40001/src/gpu/vk/GrVkResourceProvider.cpp#newcode128 src/gpu/vk/GrVkResourceProvider.cpp:128: // Iteratre through all store GrVkSamplers ...
4 years, 9 months ago (2016-03-03 18:32:59 UTC) #4
egdaniel
https://codereview.chromium.org/1765523002/diff/40001/src/gpu/vk/GrVkResourceProvider.cpp File src/gpu/vk/GrVkResourceProvider.cpp (right): https://codereview.chromium.org/1765523002/diff/40001/src/gpu/vk/GrVkResourceProvider.cpp#newcode128 src/gpu/vk/GrVkResourceProvider.cpp:128: // Iteratre through all store GrVkSamplers and unref them ...
4 years, 9 months ago (2016-03-04 15:25:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765523002/60001
4 years, 9 months ago (2016-03-04 15:25:18 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:35:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8b6394c24f755db39936e4e5111a3f251cc56857

Powered by Google App Engine
This is Rietveld 408576698