Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Side by Side Diff: src/gpu/vk/GrVkResourceProvider.cpp

Issue 1765523002: Add a cache of GrVkSamplers in GrVkResourceProvider. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/vk/GrVkResourceProvider.h ('k') | src/gpu/vk/GrVkSampler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "GrVkResourceProvider.h" 8 #include "GrVkResourceProvider.h"
9 9
10 #include "GrTextureParams.h"
10 #include "GrVkCommandBuffer.h" 11 #include "GrVkCommandBuffer.h"
11 #include "GrVkPipeline.h" 12 #include "GrVkPipeline.h"
12 #include "GrVkRenderPass.h" 13 #include "GrVkRenderPass.h"
14 #include "GrVkSampler.h"
13 #include "GrVkUtil.h" 15 #include "GrVkUtil.h"
14 16
15 #ifdef SK_TRACE_VK_RESOURCES 17 #ifdef SK_TRACE_VK_RESOURCES
16 SkTDynamicHash<GrVkResource, uint32_t> GrVkResource::fTrace; 18 SkTDynamicHash<GrVkResource, uint32_t> GrVkResource::fTrace;
17 SkRandom GrVkResource::fRandom; 19 SkRandom GrVkResource::fRandom;
18 #endif 20 #endif
19 21
20 GrVkResourceProvider::GrVkResourceProvider(GrVkGpu* gpu) : fGpu(gpu) 22 GrVkResourceProvider::GrVkResourceProvider(GrVkGpu* gpu) : fGpu(gpu)
21 , fPipelineCache(VK_NUL L_HANDLE) { 23 , fPipelineCache(VK_NUL L_HANDLE) {
22 } 24 }
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 fSimpleRenderPasses.push_back(renderPass); 76 fSimpleRenderPasses.push_back(renderPass);
75 renderPass->ref(); 77 renderPass->ref();
76 return renderPass; 78 return renderPass;
77 } 79 }
78 80
79 GrVkDescriptorPool* GrVkResourceProvider::findOrCreateCompatibleDescriptorPool( 81 GrVkDescriptorPool* GrVkResourceProvider::findOrCreateCompatibleDescriptorPool(
80 const GrVkDescriptorPool::DescriptorTypeC ounts& typeCounts) { 82 const GrVkDescriptorPool::DescriptorTypeC ounts& typeCounts) {
81 return new GrVkDescriptorPool(fGpu, typeCounts); 83 return new GrVkDescriptorPool(fGpu, typeCounts);
82 } 84 }
83 85
86 GrVkSampler* GrVkResourceProvider::findOrCreateCompatibleSampler(const GrTexture Params& params) {
87 GrVkSampler* sampler = fSamplers.find(GrVkSampler::GenerateKey(params));
88 if (!sampler) {
89 sampler = GrVkSampler::Create(fGpu, params);
90 fSamplers.add(sampler);
91 }
92 SkASSERT(sampler);
93 sampler->ref();
94 return sampler;
95 }
96
84 GrVkCommandBuffer* GrVkResourceProvider::createCommandBuffer() { 97 GrVkCommandBuffer* GrVkResourceProvider::createCommandBuffer() {
85 GrVkCommandBuffer* cmdBuffer = GrVkCommandBuffer::Create(fGpu, fGpu->cmdPool ()); 98 GrVkCommandBuffer* cmdBuffer = GrVkCommandBuffer::Create(fGpu, fGpu->cmdPool ());
86 fActiveCommandBuffers.push_back(cmdBuffer); 99 fActiveCommandBuffers.push_back(cmdBuffer);
87 cmdBuffer->ref(); 100 cmdBuffer->ref();
88 return cmdBuffer; 101 return cmdBuffer;
89 } 102 }
90 103
91 void GrVkResourceProvider::checkCommandBuffers() { 104 void GrVkResourceProvider::checkCommandBuffers() {
92 for (int i = fActiveCommandBuffers.count()-1; i >= 0; --i) { 105 for (int i = fActiveCommandBuffers.count()-1; i >= 0; --i) {
93 if (fActiveCommandBuffers[i]->finished(fGpu)) { 106 if (fActiveCommandBuffers[i]->finished(fGpu)) {
(...skipping 11 matching lines...) Expand all
105 fActiveCommandBuffers[i]->unref(fGpu); 118 fActiveCommandBuffers[i]->unref(fGpu);
106 } 119 }
107 fActiveCommandBuffers.reset(); 120 fActiveCommandBuffers.reset();
108 121
109 // loop over all render passes to make sure we destroy all the internal VkRe nderPasses 122 // loop over all render passes to make sure we destroy all the internal VkRe nderPasses
110 for (int i = 0; i < fSimpleRenderPasses.count(); ++i) { 123 for (int i = 0; i < fSimpleRenderPasses.count(); ++i) {
111 fSimpleRenderPasses[i]->unref(fGpu); 124 fSimpleRenderPasses[i]->unref(fGpu);
112 } 125 }
113 fSimpleRenderPasses.reset(); 126 fSimpleRenderPasses.reset();
114 127
128 // Iterate through all store GrVkSamplers and unref them before resetting th e hash.
129 SkTDynamicHash<GrVkSampler, uint8_t>::Iter iter(&fSamplers);
130 for (; !iter.done(); ++iter) {
131 (*iter).unref(fGpu);
132 }
133 fSamplers.reset();
134
115 #ifdef SK_TRACE_VK_RESOURCES 135 #ifdef SK_TRACE_VK_RESOURCES
116 SkASSERT(0 == GrVkResource::fTrace.count()); 136 SkASSERT(0 == GrVkResource::fTrace.count());
117 #endif 137 #endif
118 138
119 GR_VK_CALL(fGpu->vkInterface(), DestroyPipelineCache(fGpu->device(), fPipeli neCache, nullptr)); 139 GR_VK_CALL(fGpu->vkInterface(), DestroyPipelineCache(fGpu->device(), fPipeli neCache, nullptr));
120 fPipelineCache = VK_NULL_HANDLE; 140 fPipelineCache = VK_NULL_HANDLE;
121 } 141 }
122 142
123 void GrVkResourceProvider::abandonResources() { 143 void GrVkResourceProvider::abandonResources() {
124 // release our current command buffers 144 // release our current command buffers
125 for (int i = 0; i < fActiveCommandBuffers.count(); ++i) { 145 for (int i = 0; i < fActiveCommandBuffers.count(); ++i) {
126 SkASSERT(fActiveCommandBuffers[i]->finished(fGpu)); 146 SkASSERT(fActiveCommandBuffers[i]->finished(fGpu));
127 fActiveCommandBuffers[i]->unrefAndAbandon(); 147 fActiveCommandBuffers[i]->unrefAndAbandon();
128 } 148 }
129 fActiveCommandBuffers.reset(); 149 fActiveCommandBuffers.reset();
130 150
131 for (int i = 0; i < fSimpleRenderPasses.count(); ++i) { 151 for (int i = 0; i < fSimpleRenderPasses.count(); ++i) {
132 fSimpleRenderPasses[i]->unrefAndAbandon(); 152 fSimpleRenderPasses[i]->unrefAndAbandon();
133 } 153 }
134 fSimpleRenderPasses.reset(); 154 fSimpleRenderPasses.reset();
135 155
156 // Iterate through all store GrVkSamplers and unrefAndAbandon them before re setting the hash.
157 SkTDynamicHash<GrVkSampler, uint8_t>::Iter iter(&fSamplers);
158 for (; !iter.done(); ++iter) {
159 (*iter).unrefAndAbandon();
160 }
161 fSamplers.reset();
162
136 #ifdef SK_TRACE_VK_RESOURCES 163 #ifdef SK_TRACE_VK_RESOURCES
137 SkASSERT(0 == GrVkResource::fTrace.count()); 164 SkASSERT(0 == GrVkResource::fTrace.count());
138 #endif 165 #endif
139 fPipelineCache = VK_NULL_HANDLE; 166 fPipelineCache = VK_NULL_HANDLE;
140 } 167 }
OLDNEW
« no previous file with comments | « src/gpu/vk/GrVkResourceProvider.h ('k') | src/gpu/vk/GrVkSampler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698