Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1765283002: [Telemetry] Print out console output instead of page state on TimeoutException (Closed)

Created:
4 years, 9 months ago by nednguyen
Modified:
4 years, 9 months ago
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Print out console output instead of page state on TimeoutException BUG=chromium:591729 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e20f14d4f98115780645a8bdee221a9bf4b3980d

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Remove dump_page_state_on_timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -63 lines) Patch
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py View 1 chunk +6 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_console.py View 2 chunks +27 lines, -26 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py View 3 chunks +4 lines, -6 lines 0 comments Download
M telemetry/telemetry/internal/browser/tab_unittest.py View 1 chunk +19 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/browser/web_contents.py View 1 2 3 chunks +5 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nednguyen
4 years, 9 months ago (2016-03-08 02:14:09 UTC) #5
aiolos (Not reviewing)
dev_server_unittest.py appears to be broken, which is blocking the CQ. https://codereview.chromium.org/1765283002/diff/40001/telemetry/telemetry/internal/browser/web_contents.py File telemetry/telemetry/internal/browser/web_contents.py (right): https://codereview.chromium.org/1765283002/diff/40001/telemetry/telemetry/internal/browser/web_contents.py#newcode76 ...
4 years, 9 months ago (2016-03-08 03:28:06 UTC) #6
nednguyen
The CQ problem should be fixed by now https://codereview.chromium.org/1765283002/diff/40001/telemetry/telemetry/internal/browser/web_contents.py File telemetry/telemetry/internal/browser/web_contents.py (right): https://codereview.chromium.org/1765283002/diff/40001/telemetry/telemetry/internal/browser/web_contents.py#newcode76 telemetry/telemetry/internal/browser/web_contents.py:76: dump_page_console_on_timeout=True): ...
4 years, 9 months ago (2016-03-08 03:30:03 UTC) #7
aiolos (Not reviewing)
lgtm
4 years, 9 months ago (2016-03-08 03:41:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765283002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765283002/80001
4 years, 9 months ago (2016-03-08 04:08:28 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 04:22:42 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698