Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

Issue 1765283002: [Telemetry] Print out console output instead of page state on TimeoutException (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Remove dump_page_state_on_timeout Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py
index 7e91fe3c869509b424cee8ffe9cfa23f0e795df4..c3d08b9ba5b57fea8233753bf4661b32f7703647 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
import re
-import StringIO
from telemetry.core import util
from telemetry.testing import tab_test_case
@@ -11,9 +10,6 @@ from telemetry.testing import tab_test_case
class TabConsoleTest(tab_test_case.TabTestCase):
def testConsoleOutputStream(self):
- stream = StringIO.StringIO()
- self._tab._inspector_backend._console.message_output_stream = stream
-
self.Navigate('page_that_logs_to_console.html')
initial = self._tab.EvaluateJavaScript('window.__logCount')
@@ -22,10 +18,12 @@ class TabConsoleTest(tab_test_case.TabTestCase):
return current > initial
util.WaitFor(GotLog, 5)
- lines = [l for l in stream.getvalue().split('\n') if len(l)]
+ console_output = (
+ self._tab._inspector_backend.GetCurrentConsoleOutputBuffer())
+ lines = [l for l in console_output.split('\n') if len(l)]
self.assertTrue(len(lines) >= 1)
for line in lines:
prefix = 'http://(.+)/page_that_logs_to_console.html:9'
- expected_line = 'At %s: Hello, world' % prefix
+ expected_line = r'\(log\) %s: Hello, world' % prefix
self.assertTrue(re.match(expected_line, line))

Powered by Google App Engine
This is Rietveld 408576698