Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: telemetry/telemetry/internal/browser/tab_unittest.py

Issue 1765283002: [Telemetry] Print out console output instead of page state on TimeoutException (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Remove dump_page_state_on_timeout Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/browser/tab_unittest.py
diff --git a/telemetry/telemetry/internal/browser/tab_unittest.py b/telemetry/telemetry/internal/browser/tab_unittest.py
index 70d01e50b88a8864c69a3b4211f1c92523df02fc..f1f67fdf922dd408b24717229bba6d22cdc71ffd 100644
--- a/telemetry/telemetry/internal/browser/tab_unittest.py
+++ b/telemetry/telemetry/internal/browser/tab_unittest.py
@@ -67,6 +67,25 @@ class TabTest(tab_test_case.TabTestCase):
lambda: self._tab.Navigate('chrome://crash',
timeout=30))
+ def testTimeoutExceptionIncludeConsoleMessage(self):
+ self._tab.EvaluateJavaScript("""
+ window.__set_timeout_called = false;
+ function buggyReference() {
+ window.__set_timeout_called = true;
+ if (window.__one.not_defined === undefined)
+ window.__one = 1;
+ }
+ setTimeout(buggyReference, 200);""")
+ self._tab.WaitForJavaScriptExpression(
+ 'window.__set_timeout_called === true', 5)
+ with self.assertRaises(exceptions.TimeoutException) as context:
+ self._tab.WaitForJavaScriptExpression(
+ 'window.__one === 1', 1)
+ self.assertIn(
+ ("(error) :5: Uncaught TypeError: Cannot read property 'not_defined' "
+ 'of undefined\n'),
+ context.exception.message)
+
@decorators.Enabled('has tabs')
def testActivateTab(self):
util.WaitFor(lambda: _IsDocumentVisible(self._tab), timeout=5)

Powered by Google App Engine
This is Rietveld 408576698