Rename WorkerContext to WorkerGlobalScope

Rename WorkerContext to WorkerGlobalScope

Rename WorkerContext to WorkerGlobalScope to match the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

There is no web-exposed behavior change as the name was not exposed to JavaScript yet.

BUG=253473
R=abarth@chromium.org, arv@chromium.org, haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153030

[haraken, 2013-06-25 11:04:10]

lgtm

[haraken, 2013-06-25 11:04:16]

lgtm

[do-not-use, 2013-06-25 12:00:47]

I found the following in Chrome browser:
chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js:217:if
(global.constructor.name == 'SharedWorkerContext') {

Should I fix this in a separate CL to avoid breakage when Blink gets rolled?

[arv (Not doing code reviews), 2013-06-25 14:34:01]

In this case I would modify metadata_dispatcher.js to do

if (global.constructor.name == 'SharedWorkerContext' ||
global.constructor.name == 'WorkerGlobalScope') {

before the roll.

then after the roll change it to

if (global.constructor.name == 'WorkerGlobalScope' ||

You can R=arv since I'm an owner of chrome/browser/resources



On Tue, Jun 25, 2013 at 8:00 AM, <ch.dumez@sisa.samsung.com> wrote:

> I found the following in Chrome browser:
> chrome/browser/resources/file_**manager/js/metadata/metadata_**
> dispatcher.js:217:if
> (global.constructor.name == 'SharedWorkerContext') {
>
> Should I fix this in a separate CL to avoid breakage when Blink gets
> rolled?
>
>
https://codereview.chromium.**org/17648006/<https://codereview.chromium.org/1...
>



-- 
erik

[arv (Not doing code reviews), 2013-06-25 14:34:25]

oh, LGTM


On Tue, Jun 25, 2013 at 10:33 AM, Erik Arvidsson <arv@chromium.org> wrote:

> In this case I would modify metadata_dispatcher.js to do
>
> if (global.constructor.name == 'SharedWorkerContext' ||
> global.constructor.name == 'WorkerGlobalScope') {
>
> before the roll.
>
> then after the roll change it to
>
> if (global.constructor.name == 'WorkerGlobalScope' ||
>
> You can R=arv since I'm an owner of chrome/browser/resources
>
>
>
> On Tue, Jun 25, 2013 at 8:00 AM, <ch.dumez@sisa.samsung.com> wrote:
>
>> I found the following in Chrome browser:
>> chrome/browser/resources/file_**manager/js/metadata/metadata_**
>> dispatcher.js:217:if
>> (global.constructor.name == 'SharedWorkerContext') {
>>
>> Should I fix this in a separate CL to avoid breakage when Blink gets
>> rolled?
>>
>>
https://codereview.chromium.**org/17648006/<https://codereview.chromium.org/1...
>>
>
>
>
> --
> erik
>
>
>


-- 
erik

[do-not-use, 2013-06-25 14:35:44]

On 2013/06/25 14:34:01, arv wrote:
> In this case I would modify metadata_dispatcher.js to do
> 
> if (global.constructor.name == 'SharedWorkerContext' ||
> global.constructor.name == 'WorkerGlobalScope') {
> 
> before the roll.
> 
> then after the roll change it to
> 
> if (global.constructor.name == 'WorkerGlobalScope' ||
> 
> You can R=arv since I'm an owner of chrome/browser/resources

Thanks arv, it sounds like a good idea. I'll do that.

[commit-bot: I haz the power, 2013-06-25 19:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17648006/12001

[do-not-use, 2013-06-25 19:08:15]

Landed the Chromium fix in
https://src.chromium.org/viewvc/chrome?view=rev&revision=208533 so this one is
ready to land.

[commit-bot: I haz the power, 2013-06-25 19:20:33]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-06-25 21:12:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17648006/19001

[do-not-use, 2013-06-25 21:21:13]

On 2013/06/25 21:12:58, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://chromium-status.appspot.com/cq/ch.dumez%40sisa.samsung.com/17648006/1...

Could someone please review the changes under Source/WebKit/chromium/src/ ?
Presubmit is failing because those changes don't have L-G-T-M.

[abarth-chromium, 2013-06-25 21:26:46]

rs=me LGTM bbw

[commit-bot: I haz the power, 2013-06-25 21:35:11]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-06-25 21:41:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17648006/19001

[do-not-use, 2013-06-25 21:56:34]

Committed patchset #4 manually as r153030 (presubmit successful).