Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1764553002: Make SearchMatch usable for the new index - remove the element field. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make SearchMatch usable for the new index - remove the element field. The 'element' is still accessible, but as a computed property. In many cases we don't need to know the containing element, and need only the unit source, or the LibraryElement. So, by computing it on demand we may save some time and make SearchMatch usable with the new index - where we don't know the Element. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/80531d974dff8e9b3b69ceb70beaed6ebd691681

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-03 03:26:09 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-03 14:59:17 UTC) #2
scheglov
4 years, 9 months ago (2016-03-03 16:41:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80531d974dff8e9b3b69ceb70beaed6ebd691681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698