pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart - Issue 1764553002: Make SearchMatch usable for the new index - remove the element field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 1764553002: Make SearchMatch usable for the new index - remove the element field. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/rename.dart ('k') | pkg/analysis_server/lib/src/services/search/search_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

index 460896e949c3ebb950528d098458106444c76eca..23e03426174678ad57c5eb1436b720407c2394d8 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

@@ -86,7 +86,13 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {

} else {

sourceRange = rangeStartLength(element.nameEnd, 0);

}

- String file = element.source.fullName;

- return new SourceReference(file, sourceRange, element, true, true);

+ return new SourceReference(new SearchMatch(

+ element.context,

+ element.library.source.uri.toString(),

+ element.source.uri.toString(),

+ MatchKind.DECLARATION,

+ sourceRange,

+ true,

+ true));

}