pkg/analysis_server/lib/src/services/refactoring/rename.dart - Issue 1764553002: Make SearchMatch usable for the new index - remove the element field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename.dart

Issue 1764553002: Make SearchMatch usable for the new index - remove the element field. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename.dart b/pkg/analysis_server/lib/src/services/refactoring/rename.dart

index ec36d008a7ece0f066fb47cc848f61771fe90cf5..b6f54c12b78c879c0e0716c406d717453d3aa6d9 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename.dart

@@ -98,7 +98,7 @@ bool isReferenceInLocalRange(LocalElement localElement, SearchMatch reference) {

return false;

}

Source localSource = localElement.source;

- Source referenceSource = reference.element.source;

+ Source referenceSource = reference.unitSource;

SourceRange localRange = localElement.visibleRange;

SourceRange referenceRange = reference.sourceRange;

return referenceSource == localSource &&