Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1764183002: Relocate the specialized linear gradient interval builder (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Relocate the specialized linear gradient interval builder The specialized interval setup works really well for (4f) linear gradients, but it seems unlikely to benefit other gradient subclasses. Since it gets in the way of a general/fallback gradient impl, let's move this code to Sk4fLinearGradient. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1764183002 Committed: https://skia.googlesource.com/skia/+/7520fc4ad3a12476a27f098e7c00847ae0e5bcf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -255 lines) Patch
M src/effects/gradients/Sk4fGradientBase.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/effects/gradients/Sk4fGradientBase.cpp View 4 chunks +0 lines, -247 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 1 chunk +253 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
f(malita)
4 years, 9 months ago (2016-03-04 18:33:23 UTC) #2
reed1
lgtm
4 years, 9 months ago (2016-03-04 18:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764183002/1
4 years, 9 months ago (2016-03-04 18:44:00 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 19:01:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7520fc4ad3a12476a27f098e7c00847ae0e5bcf4

Powered by Google App Engine
This is Rietveld 408576698