Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 1762983002: Only honor break-* values when appropriate. (Closed)

Created:
4 years, 9 months ago by mstensho (USE GERRIT)
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only honor break-* values when appropriate. Only honor column-specific break property values if inside a multicol container, and only honor pagination-specific break property values if inside some kind of pagination container (printing or paged overflow). For breaking inside paged overflow containers, honor page values, not column values. The paged overflow implementation sits on top of the multicol implementation, which means that it's flowthread-based. But that's just an implementation detail. Paged overflow containers don't establish columns -- it establishes pages. Had to update one test, since it relied on -webkit-column-break-* working inside a paged overflow container, which no longer is the case. Some unit tests needed an update too. R=leviw@chromium.org BUG=223068 Committed: https://crrev.com/f307247b890c281aee1cc7e6382c0ddb5d760abf Cr-Commit-Position: refs/heads/master@{#380797}

Patch Set 1 #

Patch Set 2 : Correct assertion. #

Patch Set 3 : Update some unit tests too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -32 lines) Patch
M third_party/WebKit/LayoutTests/fast/pagination/auto-height-with-break.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/pagination/break-in-paged-overflow.html View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/pagination/break-in-paged-overflow-expected.html View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 chunks +82 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaginationTest.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mstensho (USE GERRIT)
4 years, 9 months ago (2016-03-04 17:11:52 UTC) #2
mstensho (USE GERRIT)
@leviw: ping
4 years, 9 months ago (2016-03-10 19:09:37 UTC) #3
leviw_travelin_and_unemployed
Sorry for the delay. LGTM.
4 years, 9 months ago (2016-03-11 22:03:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762983002/40001
4 years, 9 months ago (2016-03-11 22:32:50 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-12 00:11:47 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 00:12:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f307247b890c281aee1cc7e6382c0ddb5d760abf
Cr-Commit-Position: refs/heads/master@{#380797}

Powered by Google App Engine
This is Rietveld 408576698