Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1762983002: Only honor break-* values when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update some unit tests too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 // Pagination struts are either set in front of a block-level box (here) or before a line 613 // Pagination struts are either set in front of a block-level box (here) or before a line
614 // (RootInlineBox::paginationStrut()). 614 // (RootInlineBox::paginationStrut()).
615 LayoutUnit paginationStrut() const { return m_rareData ? m_rareData->m_pagin ationStrut : LayoutUnit(); } 615 LayoutUnit paginationStrut() const { return m_rareData ? m_rareData->m_pagin ationStrut : LayoutUnit(); }
616 void setPaginationStrut(LayoutUnit); 616 void setPaginationStrut(LayoutUnit);
617 void resetPaginationStrut() 617 void resetPaginationStrut()
618 { 618 {
619 if (m_rareData) 619 if (m_rareData)
620 m_rareData->m_paginationStrut = LayoutUnit(); 620 m_rareData->m_paginationStrut = LayoutUnit();
621 } 621 }
622 622
623 // Is the specified break-before or break-after value supported on this obje ct? It needs to be
624 // in-flow all the way up to a fragmentation context that supports the speci fied value.
625 bool isBreakBetweenControllable(EBreak) const;
626
627 // Is the specified break-inside value supported on this object? It needs to be contained by a
628 // fragmentation context that supports the specified value.
629 bool isBreakInsideControllable(EBreak) const;
630
631 EBreak breakAfter() const;
632 EBreak breakBefore() const;
633 EBreak breakInside() const;
634
635 static bool isForcedFragmentainerBreakValue(EBreak);
636
623 bool hasForcedBreakBefore() const; 637 bool hasForcedBreakBefore() const;
624 bool hasForcedBreakAfter() const; 638 bool hasForcedBreakAfter() const;
625 639
626 LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObjec t* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const ov erride; 640 LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObjec t* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const ov erride;
627 void mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* ancestor, L ayoutRect&, const PaintInvalidationState*) const override; 641 void mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* ancestor, L ayoutRect&, const PaintInvalidationState*) const override;
628 virtual void invalidatePaintForOverhangingFloats(bool paintAllDescendants); 642 virtual void invalidatePaintForOverhangingFloats(bool paintAllDescendants);
629 643
630 LayoutUnit containingBlockLogicalHeightForGetComputedStyle() const; 644 LayoutUnit containingBlockLogicalHeightForGetComputedStyle() const;
631 645
632 LayoutUnit containingBlockLogicalWidthForContent() const override; 646 LayoutUnit containingBlockLogicalWidthForContent() const override;
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
1128 // Otherwise, there will two line box wrappers keeping the reference to this layoutObject, and 1142 // Otherwise, there will two line box wrappers keeping the reference to this layoutObject, and
1129 // only one will be notified when the layoutObject is getting destroyed. The second line box wrapper 1143 // only one will be notified when the layoutObject is getting destroyed. The second line box wrapper
1130 // will keep a stale reference. 1144 // will keep a stale reference.
1131 if (UNLIKELY(m_inlineBoxWrapper != nullptr)) 1145 if (UNLIKELY(m_inlineBoxWrapper != nullptr))
1132 deleteLineBoxWrapper(); 1146 deleteLineBoxWrapper();
1133 } 1147 }
1134 1148
1135 m_inlineBoxWrapper = boxWrapper; 1149 m_inlineBoxWrapper = boxWrapper;
1136 } 1150 }
1137 1151
1152 inline bool LayoutBox::isForcedFragmentainerBreakValue(EBreak breakValue)
1153 {
1154 return breakValue == BreakColumn
1155 || breakValue == BreakLeft
1156 || breakValue == BreakPage
1157 || breakValue == BreakRecto
1158 || breakValue == BreakRight
1159 || breakValue == BreakVerso;
1160 }
1161
1138 } // namespace blink 1162 } // namespace blink
1139 1163
1140 #endif // LayoutBox_h 1164 #endif // LayoutBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698