Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: third_party/WebKit/Source/core/layout/PaginationTest.cpp

Issue 1762983002: Only honor break-* values when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update some unit tests too Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/PaginationTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/PaginationTest.cpp b/third_party/WebKit/Source/core/layout/PaginationTest.cpp
index 3c1e97d406550b0dae3a5025bf325471bed011dd..7df64f8dc652e04f96c77aeb5387dfea033125d3 100644
--- a/third_party/WebKit/Source/core/layout/PaginationTest.cpp
+++ b/third_party/WebKit/Source/core/layout/PaginationTest.cpp
@@ -90,7 +90,7 @@ TEST_F(PaginationStrutTest, BreakBefore)
setBodyInnerHTML(
"<div style='overflow:-webkit-paged-y; height:400px; line-height:50px;'>"
" <div id='block1'>line1</div>"
- " <div id='block2' style='-webkit-column-break-before:always;'>line2</div>"
+ " <div id='block2' style='break-before:page;'>line2</div>"
"</div>");
EXPECT_EQ(0, strutForBox("block1"));
EXPECT_EQ(0, strutForLine("block1", 0));
@@ -120,7 +120,7 @@ TEST_F(PaginationStrutTest, BlockWithStrutPropagatedFromUnbreakableInnerBlock)
"<div style='overflow:-webkit-paged-y; height:400px; line-height:150px;'>"
" <div id='block1'>line1</div>"
" <div id='block2' style='padding-top:2px;'>"
- " <div id='innerBlock' style='padding-top:2px; -webkit-column-break-inside:avoid;'>"
+ " <div id='innerBlock' style='padding-top:2px; break-inside:avoid;'>"
" line2<br>"
" line3<br>"
" </div>"
@@ -140,7 +140,7 @@ TEST_F(PaginationStrutTest, InnerBlockWithBreakBefore)
"<div style='overflow:-webkit-paged-y; height:200px; line-height:150px;'>"
" <div id='block1'>line1</div>"
" <div id='block2' style='padding-top:2px;'>"
- " <div id='innerBlock' style='padding-top:2px; -webkit-column-break-before:always;'>line2</div>"
+ " <div id='innerBlock' style='padding-top:2px; break-before:page;'>line2</div>"
" </div>"
"</div>");
EXPECT_EQ(0, strutForBox("block1"));
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698