Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1762963002: Revert of Extract state management from WebMediaPlayerImpl. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, halliwell, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract state management from WebMediaPlayerImpl. (patchset #32 id:620001 of https://codereview.chromium.org/1641423002/ ) Reason for revert: Causes a pair of layout test failures on linux(dbg), https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/6332 It _might_ also be behind the MSan failures https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8850 , but not locally confirmed. Original issue's description: > Extract state management from WebMediaPlayerImpl. > > WMPI recieves operations at any time but is backed by Pipeline which can > only perform one operation at a time. This CL creates a helper class > (PipelineController) to translate between the two so that WMPI does not need > to handle the full cross product of states. > > Committed: https://crrev.com/aafb73c6460349c508a49e6e6de21e774ec80b5c > Cr-Commit-Position: refs/heads/master@{#379168} TBR=dalecurtis@chromium.org,wolenetz@chromium.org,xhwang@chromium.org,sandersd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -897 lines) Patch
M media/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +0 lines, -67 lines 0 comments Download
M media/base/mock_filters.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.h View 7 chunks +56 lines, -27 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 19 chunks +302 lines, -114 lines 0 comments Download
D media/filters/pipeline_controller.h View 1 chunk +0 lines, -177 lines 0 comments Download
D media/filters/pipeline_controller.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D media/filters/pipeline_controller_unittest.cc View 1 chunk +0 lines, -212 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sof
Created Revert of Extract state management from WebMediaPlayerImpl.
4 years, 9 months ago (2016-03-04 07:57:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762963002/1
4 years, 9 months ago (2016-03-04 07:58:05 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:58:35 UTC) #4
Failed to apply patch for media/media.gyp:
While running git apply --index -3 -p1;
  error: patch failed: media/media.gyp:536
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: media/media.gyp: patch does not apply

Patch:       media/media.gyp
Index: media/media.gyp
diff --git a/media/media.gyp b/media/media.gyp
index
d2cc2a93eea889c5c0e66b547dfc9b0e6e341646..a2b05a0e0aafd5119454713e757e7b021774d4ec
100644
--- a/media/media.gyp
+++ b/media/media.gyp
@@ -536,8 +536,6 @@
         'filters/opus_audio_decoder.h',
         'filters/opus_constants.cc',
         'filters/opus_constants.h',
-        'filters/pipeline_controller.cc',
-        'filters/pipeline_controller.h',
         'filters/source_buffer_range.cc',
         'filters/source_buffer_range.h',
         'filters/source_buffer_stream.cc',
@@ -1260,7 +1258,6 @@
         'filters/ivf_parser_unittest.cc',
         'filters/jpeg_parser_unittest.cc',
         'filters/memory_data_source_unittest.cc',
-        'filters/pipeline_controller_unittest.cc',
         'filters/source_buffer_stream_unittest.cc',
         'filters/video_cadence_estimator_unittest.cc',
         'filters/video_decoder_selector_unittest.cc',

Powered by Google App Engine
This is Rietveld 408576698