Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8459)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1762603002: Switch components/password_manager code from IPC messages to Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Impl done, unit_tests and browser_tests not ready yet Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 9f0ac4278a232da3ff5a1de968b63fff5602bab7..790acd485450d8426c3236601a6b370e6757f11f 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -33,7 +33,6 @@
#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/password_manager/content/browser/content_password_manager_driver.h"
#include "components/password_manager/content/browser/password_manager_internals_service_factory.h"
-#include "components/password_manager/content/common/credential_manager_messages.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/log_manager.h"
#include "components/password_manager/core/browser/log_receiver.h"
@@ -142,7 +141,7 @@ ChromePasswordManagerClient::ChromePasswordManagerClient(
profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
password_manager_(this),
driver_factory_(nullptr),
- credential_manager_dispatcher_(web_contents, this),
+ credential_manager_impl_(web_contents, this),
observer_(nullptr),
credentials_filter_(this,
base::Bind(&GetSyncService, profile_),
@@ -336,8 +335,7 @@ void ChromePasswordManagerClient::NotifySuccessfulLoginWithExistingPassword(
possible_auto_sign_in_->password_value == form.password_value &&
possible_auto_sign_in_->origin == form.origin) {
PromptUserToEnableAutosigninIfNecessary();
- if (form.skip_zero_click &&
- credential_manager_dispatcher_.IsZeroClickAllowed() &&
+ if (form.skip_zero_click && credential_manager_impl_.IsZeroClickAllowed() &&
GetPasswordStore()) {
autofill::PasswordForm update(form);
update.skip_zero_click = false;
@@ -619,3 +617,21 @@ const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager()
const {
return log_manager_.get();
}
+
+// static
+void ChromePasswordManagerClient::BindCredentialManager(
+ content::RenderFrameHost* render_frame_host,
+ password_manager::mojom::CredentialManagerRequest request) {
+ content::WebContents* web_contents =
+ content::WebContents::FromRenderFrameHost(render_frame_host);
+ if (!web_contents) {
+ NOTREACHED();
+ return;
vabr (Chromium) 2016/03/09 16:26:29 The code style says: "do not handle DCHECK() failu
leonhsl(Using Gerrit) 2016/03/10 06:42:41 Done.
+ }
+
+ ChromePasswordManagerClient* instance =
+ ChromePasswordManagerClient::FromWebContents(web_contents);
+ // ChromePasswordManagerClient instance should have been created already.
vabr (Chromium) 2016/03/09 16:26:29 nit: You can drop the comment, the DCHECK says ess
leonhsl(Using Gerrit) 2016/03/10 06:42:41 Done.
+ DCHECK(instance);
+ instance->credential_manager_impl_.BindRequest(std::move(request));
+}

Powered by Google App Engine
This is Rietveld 408576698