Switch components/password_manager code from IPC messages to Mojo.

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 15 matching lines @@
 #include "chrome/common/features.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/content/browser/content_autofill_driver.h"
 #include "components/autofill/content/browser/content_autofill_driver_factory.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/core/browser/password_generator.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/browser_sync/browser/profile_sync_service.h"
 #include "components/password_manager/content/browser/content_password_manager_driver.h"
 #include "components/password_manager/content/browser/password_manager_internals_service_factory.h"
-#include "components/password_manager/content/common/credential_manager_messages.h"
 #include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
 #include "components/password_manager/core/browser/log_manager.h"
 #include "components/password_manager/core/browser/log_receiver.h"
 #include "components/password_manager/core/browser/password_bubble_experiment.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager_internals_service.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/password_manager/core/browser/password_manager_settings_migration_experiment.h"
 #include "components/password_manager/core/browser/password_manager_util.h"
 #include "components/password_manager/core/common/credential_manager_types.h"
@@ skipping 88 matching lines @@
       new ChromePasswordManagerClient(contents, autofill_client));
 }
 
 ChromePasswordManagerClient::ChromePasswordManagerClient(
     content::WebContents* web_contents,
     autofill::AutofillClient* autofill_client)
     : content::WebContentsObserver(web_contents),
       profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
       password_manager_(this),
       driver_factory_(nullptr),
-      credential_manager_dispatcher_(web_contents, this),
+      credential_manager_impl_(web_contents, this),
       observer_(nullptr),
       credentials_filter_(this,
                           base::Bind(&GetSyncService, profile_),
                           base::Bind(&GetSigninManager, profile_)) {
   ContentPasswordManagerDriverFactory::CreateForWebContents(web_contents, this,
                                                             autofill_client);
   driver_factory_ =
       ContentPasswordManagerDriverFactory::FromWebContents(web_contents);
   log_manager_ = password_manager::LogManager::Create(
       password_manager::PasswordManagerInternalsServiceFactory::
@@ skipping 173 matching lines @@
 
 void ChromePasswordManagerClient::NotifySuccessfulLoginWithExistingPassword(
     const autofill::PasswordForm& form) {
   if (!possible_auto_sign_in_)
     return;
 
   if (possible_auto_sign_in_->username_value == form.username_value &&
       possible_auto_sign_in_->password_value == form.password_value &&
       possible_auto_sign_in_->origin == form.origin) {
     PromptUserToEnableAutosigninIfNecessary();
-    if (form.skip_zero_click &&
-        credential_manager_dispatcher_.IsZeroClickAllowed() &&
+    if (form.skip_zero_click && credential_manager_impl_.IsZeroClickAllowed() &&
         GetPasswordStore()) {
       autofill::PasswordForm update(form);
       update.skip_zero_click = false;
       GetPasswordStore()->UpdateLogin(update);
     }
   }
   possible_auto_sign_in_.reset();
 }
 
 void ChromePasswordManagerClient::AutomaticPasswordSave(
@@ skipping 261 matching lines @@
 
 const password_manager::CredentialsFilter*
 ChromePasswordManagerClient::GetStoreResultFilter() const {
   return &credentials_filter_;
 }
 
 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager()
     const {
   return log_manager_.get();
 }
+
+// static
+void ChromePasswordManagerClient::BindCredentialManager(
+    content::RenderFrameHost* render_frame_host,
+    password_manager::mojom::CredentialManagerRequest request) {
+  content::WebContents* web_contents =
+      content::WebContents::FromRenderFrameHost(render_frame_host);
+  if (!web_contents) {
+    NOTREACHED();
+    return;

[vabr (Chromium), 2016/03/09 16:26:29]

The code style says: "do not handle DCHECK() failures" [1]. Please replace lines
627-630 with DCHECK(web_contents).

[1]
http://dev.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-

[leonhsl(Using Gerrit), 2016/03/10 06:42:41]

Done.

+  }
+
+  ChromePasswordManagerClient* instance =
+      ChromePasswordManagerClient::FromWebContents(web_contents);
+  // ChromePasswordManagerClient instance should have been created already.

[vabr (Chromium), 2016/03/09 16:26:29]

nit: You can drop the comment, the DCHECK says essentially the same thing.

[leonhsl(Using Gerrit), 2016/03/10 06:42:41]

Done.

+  DCHECK(instance);
+  instance->credential_manager_impl_.BindRequest(std::move(request));
+}