Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1762603002: Switch components/password_manager code from IPC messages to Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Impl done, unit_tests and browser_tests not ready yet Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index e645f6949924cc18e7790b992aa83209822d6919..1a2256d0815b3cb69f12d4bc04aaec86622bc1aa 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -12,7 +12,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
#include "components/password_manager/content/browser/content_password_manager_driver_factory.h"
-#include "components/password_manager/content/browser/credential_manager_dispatcher.h"
+#include "components/password_manager/content/browser/credential_manager_impl.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/password_manager_client.h"
#include "components/password_manager/sync/browser/sync_credentials_filter.h"
@@ -104,6 +104,10 @@ class ChromePasswordManagerClient
// the sad old Infobar UI.
static bool IsTheHotNewBubbleUIEnabled();
+ static void BindCredentialManager(
+ content::RenderFrameHost* render_frame_host,
+ password_manager::mojom::CredentialManagerRequest request);
+
protected:
// Callable for tests.
ChromePasswordManagerClient(content::WebContents* web_contents,
@@ -165,8 +169,13 @@ class ChromePasswordManagerClient
password_manager::ContentPasswordManagerDriverFactory* driver_factory_;
- password_manager::CredentialManagerDispatcher
- credential_manager_dispatcher_;
+ // Mojo CredentialManager impl instance,
vabr (Chromium) 2016/03/09 16:26:29 nit: I'm not sure I understand the first sentence,
leonhsl(Using Gerrit) 2016/03/10 06:42:41 Done. Removed the redundant sentence.
+ // keep its lifecycle untouch, keep the 1:1 mapping with
+ // ChromePasswordManagerClient instance and WebContents instance.
+ // As a mojo service, will be registered into service registry
+ // of the main frame host by ChromeContentBrowserClient
+ // once main frame host was created.
+ password_manager::CredentialManagerImpl credential_manager_impl_;
// Observer for password generation popup.
autofill::PasswordGenerationPopupObserver* observer_;

Powered by Google App Engine
This is Rietveld 408576698