Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

Issue 1762373002: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds ContentSettingBubbleContents::Show (show arrow on pause) Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/location_bar/content_setting_image_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/content_setting_image_view.cc
diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
index e88ab5c3f5717dfaad2fb524f3ac242e1e3be424..ec07fd69145418bef802c1ef9dd9902bc5690494 100644
--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
@@ -256,14 +256,8 @@ void ContentSettingImageView::OnClick() {
parent_->delegate()->GetContentSettingBubbleModelDelegate(),
web_contents, parent_->profile()),
web_contents, this, views::BubbleBorder::TOP_RIGHT);
- views::Widget* bubble_widget =
- parent_->delegate()->CreateViewsBubble(bubble_view_);
+ views::Widget* bubble_widget = bubble_view_->Show(pause_animation_);
Evan Stade 2016/03/07 18:10:37 seems like there is a behavior change here. The ar
varkha 2016/03/07 18:28:51 Yes, since there is no ink ripple active state whe
bubble_widget->AddObserver(this);
- // This is triggered by an input event, the icon will be in an active state
- // so the bubble doesn't need an arrow.
- if (ui::MaterialDesignController::IsModeMaterial())
- bubble_view_->SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
- bubble_widget->Show();
}
}
« no previous file with comments | « chrome/browser/ui/views/location_bar/content_setting_image_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698