chrome/browser/ui/views/location_bar/content_setting_image_view.h - Issue 1762373002: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.h

Issue 1762373002: Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds ContentSettingBubbleContents::Show (show arrow on pause) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | chrome/browser/ui/views/location_bar/content_setting_image_view.cc » ('j') | chrome/browser/ui/views/location_bar/content_setting_image_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/content_setting_image_view.h

diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.h b/chrome/browser/ui/views/location_bar/content_setting_image_view.h

index a6beed464000b9ef00d339bf9f39f2ed7bb1caa1..223df6b33222ff15100ad757f9715d46ce8c3d94 100644

--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.h

+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.h

@@ -16,6 +16,7 @@

#include "ui/views/view.h"

#include "ui/views/widget/widget_observer.h"

+class ContentSettingBubbleContents;

class ContentSettingImageModel;

class LocationBarView;

@@ -28,7 +29,6 @@ class FontList;

}

namespace views {

-class BubbleDelegateView;

class ImageView;

class InkDropDelegate;

class Label;

@@ -96,7 +96,7 @@ class ContentSettingImageView : public IconLabelBubbleView,

gfx::SlideAnimation slide_animator_;

bool pause_animation_;

double pause_animation_state_;

- views::BubbleDelegateView* bubble_view_;

+ ContentSettingBubbleContents* bubble_view_;

// This is used to check if the bubble was showing during the mouse pressed

// event. If this is true then the mouse released event is ignored to prevent