Corrects ContentSettingBubbleContents to show bubble with arrow when animation is paused

chrome/browser/ui/views/location_bar/content_setting_image_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/themes/theme_properties.h"
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
@@ skipping 238 matching lines @@
     slide_animator_.Reset();
   }
 
   content::WebContents* web_contents = parent_->GetWebContents();
   if (web_contents && !bubble_view_) {
     bubble_view_ = new ContentSettingBubbleContents(
                 content_setting_image_model_->CreateBubbleModel(
                     parent_->delegate()->GetContentSettingBubbleModelDelegate(),
                     web_contents, parent_->profile()),
                 web_contents, this, views::BubbleBorder::TOP_RIGHT);
-    views::Widget* bubble_widget =
-        parent_->delegate()->CreateViewsBubble(bubble_view_);
+    views::Widget* bubble_widget = bubble_view_->Show(pause_animation_);

[Evan Stade, 2016/03/07 18:10:37]

seems like there is a behavior change here. The arrow used to never show in MD,
now it depends on pause_animation_?

[varkha, 2016/03/07 18:28:51]

Yes, since there is no ink ripple active state when a label is shown during a
paused animation.

     bubble_widget->AddObserver(this);
-    // This is triggered by an input event, the icon will be in an active state
-    // so the bubble doesn't need an arrow.
-    if (ui::MaterialDesignController::IsModeMaterial())
-      bubble_view_->SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
-    bubble_widget->Show();
   }
 }
 
 void ContentSettingImageView::UpdateImage() {
   SetImage(content_setting_image_model_->GetIcon(GetTextColor()).AsImageSkia());
   image()->SetTooltipText(content_setting_image_model_->get_tooltip());
 }
 
 bool ContentSettingImageView::IsBubbleShowing() const {
   return bubble_view_ != nullptr;
 }