Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1762323002: [compiler] Move ClearExceptionFlag into Compiler. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Move ClearExceptionFlag into Compiler. The enum in question is (and should) no longer be used outside of the compiler API and hence is being moved back into the Compiler class. R=yangguo@chromium.org Committed: https://crrev.com/f53418b8ba59edebde6948f440662981569029ce Cr-Commit-Position: refs/heads/master@{#34526}

Patch Set 1 #

Patch Set 2 : More places. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-04 16:27:22 UTC) #3
Yang
lgtm
4 years, 9 months ago (2016-03-07 05:52:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762323002/20001
4 years, 9 months ago (2016-03-07 09:46:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 10:17:08 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 10:17:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f53418b8ba59edebde6948f440662981569029ce
Cr-Commit-Position: refs/heads/master@{#34526}

Powered by Google App Engine
This is Rietveld 408576698